From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Duje Mihanović" <duje@dujemihanovic.xyz>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Lee Jones" <lee@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Karel Balej" <balejk@matfyz.cz>,
"David Wronek" <david@mainlining.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC
Date: Mon, 1 Sep 2025 15:43:08 +0300 [thread overview]
Message-ID: <aLWU3AwC37jpV9W_@smile.fi.intel.com> (raw)
In-Reply-To: <5048048.31r3eYUQgx@radijator>
On Sun, Aug 31, 2025 at 10:19:38PM +0200, Duje Mihanović wrote:
> On Sunday, 31 August 2025 21:24:54 Central European Summer Time Karel Balej wrote:
> > Duje Mihanović, 2025-08-31T12:33:05+02:00:
...
> > > + iio->dev.of_node = dev->parent->of_node;
> >
> > Didn't you mean to drop this since Jonathan pointed out that it's done
> > by the core?
>
> Actually I have found that device tree consumers fail to get their IO
> channels without this line, so I left it.
because the passed device is not parent?
In any case this line is problematic. Use device_set_node() instead with the
proper dev_fwnode() parameter.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-01 12:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 10:33 [PATCH v2 0/3] Marvell 88PM886 PMIC GPADC driver Duje Mihanović
2025-08-31 10:33 ` [PATCH v2 1/3] dt-bindings: mfd: 88pm886: Add #io-channel-cells Duje Mihanović
2025-08-31 16:49 ` Krzysztof Kozlowski
2025-08-31 18:40 ` Karel Balej
2025-08-31 10:33 ` [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC Duje Mihanović
2025-08-31 19:24 ` Karel Balej
2025-08-31 20:19 ` Duje Mihanović
2025-09-01 12:43 ` Andy Shevchenko [this message]
2025-09-01 18:04 ` Jonathan Cameron
2025-09-01 15:35 ` Andy Shevchenko
2025-09-01 16:51 ` Duje Mihanović
2025-09-02 9:50 ` Andy Shevchenko
2025-09-01 18:18 ` Jonathan Cameron
2025-08-31 10:33 ` [PATCH v2 3/3] mfd: 88pm886: Add GPADC cell Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLWU3AwC37jpV9W_@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=balejk@matfyz.cz \
--cc=conor+dt@kernel.org \
--cc=david@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox