From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Francesco Lavra <flavra@baylibre.com>
Cc: "Ramona Gradinariu" <ramona.gradinariu@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl380: fix check for unavailable "INT1" interrupt
Date: Wed, 26 Nov 2025 20:13:35 +0200 [thread overview]
Message-ID: <aSdDT4upO9shVq0S@smile.fi.intel.com> (raw)
In-Reply-To: <20251126144624.24512-1-flavra@baylibre.com>
On Wed, Nov 26, 2025 at 03:46:24PM +0100, Francesco Lavra wrote:
> fwnode_irq_get_byname() returns a negative value on failure.
...
> st->irq = fwnode_irq_get_byname(dev_fwnode(st->dev), "INT1");
> - if (st->irq > 0)
> + if (st->irq < 0)
> return dev_err_probe(st->dev, -ENODEV,
Please, also fix this.
> "no interrupt name specified");
Otherwise a good catch!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-26 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 14:46 [PATCH] iio: accel: adxl380: fix check for unavailable "INT1" interrupt Francesco Lavra
2025-11-26 18:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSdDT4upO9shVq0S@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=flavra@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.gradinariu@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).