From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] staging: iio: frequency: ad9832: replace long/short with u32/u16
Date: Sat, 6 Dec 2025 18:32:54 +0200 [thread overview]
Message-ID: <aTRatkxEqIxL3EEP@smile.fi.intel.com> (raw)
In-Reply-To: <20251206054831.26045-1-dharanitharan725@gmail.com>
On Sat, Dec 06, 2025 at 05:48:31AM +0000, Dharanitharan R wrote:
> Cleanup the AD9832 header by explicitly including <linux/types.h> and
> replacing ambiguous integer types with fixed-width kernel types:
>
> - unsigned long → u32
> - unsigned short → u16
>
> This improves type clarity and ensures consistent behavior across
> architectures.
I have nothing to add to the Jonathan's review, just shift your focus to
another driver instead. And if see another platform data, kill it. We don't
use platform data approach in a new code.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-12-06 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 5:48 [PATCH v1] staging: iio: frequency: ad9832: replace long/short with u32/u16 Dharanitharan R
2025-12-06 15:42 ` Jonathan Cameron
2025-12-06 16:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTRatkxEqIxL3EEP@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dharanitharan725@gmail.com \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).