From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>, Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] iio: adc: ad9467: drop kernel.h in favor of array_size.h
Date: Mon, 8 Dec 2025 18:23:06 +0200 [thread overview]
Message-ID: <aTb7al6d5SBQBp1P@smile.fi.intel.com> (raw)
In-Reply-To: <905d3a14-1e78-469f-99f1-4c1d2299d97c@vaisala.com>
On Mon, Dec 08, 2025 at 06:21:25PM +0200, Tomas Melin wrote:
> On 08/12/2025 17:58, Andy Shevchenko wrote:
> > On Mon, Dec 08, 2025 at 05:41:20PM +0200, Tomas Melin wrote:
> >> On 08/12/2025 15:20, Andy Shevchenko wrote:
> >>> On Mon, Dec 08, 2025 at 12:30:59PM +0000, Tomas Melin wrote:
...
> > If you don't feel going that deep, than it's a (small) problem.
> >
> > As the author of a driver feature one should understand slightly more about
> > this (yeah, currently mess) header stuff. So, your first patch should add
> > missed headers, if any, that's required to your changes, this one can be
> > omitted after all.
> Well, I think reworking the headers is a sane idea, but it is not the
> topic of this series.
>
> > But on some day you will still need to understand a bit more about headers...
> >
> > TL;DR: make sure you have all needed headers for your changes in the previous
> > patch and drop this one.
>
> Hope we mean the same thing, I was thinking more like
> 1. sort current headers
> 2. add feature which adds the new header in correct location
Sure, it's even better!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-12-08 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 12:30 [PATCH v3 0/3] iio: adc: ad9467: add support for ad9211 Tomas Melin
2025-12-08 12:30 ` [PATCH v3 1/3] dt-bindings: " Tomas Melin
2025-12-08 12:30 ` [PATCH v3 2/3] iio: " Tomas Melin
2025-12-08 13:27 ` Andy Shevchenko
2025-12-08 12:30 ` [PATCH v3 3/3] iio: adc: ad9467: drop kernel.h in favor of array_size.h Tomas Melin
2025-12-08 13:20 ` Andy Shevchenko
2025-12-08 15:41 ` Tomas Melin
2025-12-08 15:58 ` Andy Shevchenko
2025-12-08 16:21 ` Tomas Melin
2025-12-08 16:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTb7al6d5SBQBp1P@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).