* [PATCH] iio: adc: ad7476: Remove duplicate include
@ 2026-01-07 8:29 Chen Ni
2026-01-07 15:29 ` Andy Shevchenko
2026-01-08 6:06 ` Matti Vaittinen
0 siblings, 2 replies; 4+ messages in thread
From: Chen Ni @ 2026-01-07 8:29 UTC (permalink / raw)
To: lars, Michael.Hennerich, mazziesaccount, jic23, dlechner, nuno.sa,
andy
Cc: linux-iio, linux-kernel, Chen Ni
Remove duplicate inclusion of linux/bitops.h.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/iio/adc/ad7476.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
index 1bec6657394c..21d3f6aae972 100644
--- a/drivers/iio/adc/ad7476.c
+++ b/drivers/iio/adc/ad7476.c
@@ -16,7 +16,6 @@
#include <linux/gpio/consumer.h>
#include <linux/err.h>
#include <linux/module.h>
-#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/iio/iio.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7476: Remove duplicate include
2026-01-07 8:29 [PATCH] iio: adc: ad7476: Remove duplicate include Chen Ni
@ 2026-01-07 15:29 ` Andy Shevchenko
2026-01-08 6:06 ` Matti Vaittinen
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-01-07 15:29 UTC (permalink / raw)
To: Chen Ni
Cc: lars, Michael.Hennerich, mazziesaccount, jic23, dlechner, nuno.sa,
andy, linux-iio, linux-kernel
On Wed, Jan 07, 2026 at 04:29:20PM +0800, Chen Ni wrote:
> Remove duplicate inclusion of linux/bitops.h.
...
> --- a/drivers/iio/adc/ad7476.c
> +++ b/drivers/iio/adc/ad7476.c
> #include <linux/gpio/consumer.h>
> #include <linux/err.h>
> #include <linux/module.h>
> -#include <linux/bitops.h>
> #include <linux/delay.h>
Can you actually sort the headers alphabetically so this will be visible change
(in terms of the context)?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7476: Remove duplicate include
2026-01-07 8:29 [PATCH] iio: adc: ad7476: Remove duplicate include Chen Ni
2026-01-07 15:29 ` Andy Shevchenko
@ 2026-01-08 6:06 ` Matti Vaittinen
2026-01-11 13:16 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Matti Vaittinen @ 2026-01-08 6:06 UTC (permalink / raw)
To: Chen Ni, lars, Michael.Hennerich, jic23, dlechner, nuno.sa, andy
Cc: linux-iio, linux-kernel
On 07/01/2026 10:29, Chen Ni wrote:
> Remove duplicate inclusion of linux/bitops.h.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
I would also appreciate having the includes alphabetically ordered as
Andy suggested. This, however, is a fine fix as it is so:
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/iio/adc/ad7476.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> index 1bec6657394c..21d3f6aae972 100644
> --- a/drivers/iio/adc/ad7476.c
> +++ b/drivers/iio/adc/ad7476.c
> @@ -16,7 +16,6 @@
> #include <linux/gpio/consumer.h>
> #include <linux/err.h>
> #include <linux/module.h>
> -#include <linux/bitops.h>
> #include <linux/delay.h>
>
> #include <linux/iio/iio.h>
--
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7476: Remove duplicate include
2026-01-08 6:06 ` Matti Vaittinen
@ 2026-01-11 13:16 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2026-01-11 13:16 UTC (permalink / raw)
To: Matti Vaittinen
Cc: Chen Ni, lars, Michael.Hennerich, dlechner, nuno.sa, andy,
linux-iio, linux-kernel
On Thu, 8 Jan 2026 08:06:13 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 07/01/2026 10:29, Chen Ni wrote:
> > Remove duplicate inclusion of linux/bitops.h.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>
> I would also appreciate having the includes alphabetically ordered as
> Andy suggested. This, however, is a fine fix as it is so:
>
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Applied this one. As Andy observes in v2 review the first patch
should be this anyway!
Thanks,
Jonathan
>
> > ---
> > drivers/iio/adc/ad7476.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> > index 1bec6657394c..21d3f6aae972 100644
> > --- a/drivers/iio/adc/ad7476.c
> > +++ b/drivers/iio/adc/ad7476.c
> > @@ -16,7 +16,6 @@
> > #include <linux/gpio/consumer.h>
> > #include <linux/err.h>
> > #include <linux/module.h>
> > -#include <linux/bitops.h>
> > #include <linux/delay.h>
> >
> > #include <linux/iio/iio.h>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-11 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 8:29 [PATCH] iio: adc: ad7476: Remove duplicate include Chen Ni
2026-01-07 15:29 ` Andy Shevchenko
2026-01-08 6:06 ` Matti Vaittinen
2026-01-11 13:16 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox