From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: SeungJu Cheon <suunj1331@gmail.com>
Cc: antoniu.miclaus@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio:frequency:adf4377: Fix duplicated soft reset mask
Date: Tue, 30 Dec 2025 14:57:08 +0200 [thread overview]
Message-ID: <aVPMJFt07PG9oHMU@smile.fi.intel.com> (raw)
In-Reply-To: <20251230123609.210454-1-suunj1331@gmail.com>
On Tue, Dec 30, 2025 at 09:36:09PM +0900, SeungJu Cheon wrote:
> The regmap_read_poll_timeout() uses ADF4377_0000_SOFT_RESET_R_MSK
> twice instead of checking both SOFT_RESET_MSK (bit 0) and
> SOFT_RESET_R_MSK (bit 7). This causes incomplete reset status check.
>
> Fix by using both masks as done in regmap_update_bits() above.
Shouldn't we have a Fixes tag here?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-30 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 12:36 [PATCH] iio:frequency:adf4377: Fix duplicated soft reset mask SeungJu Cheon
2025-12-30 12:57 ` Andy Shevchenko [this message]
2025-12-30 13:21 ` [PATCH v2] " SeungJu Cheon
2025-12-31 11:19 ` Andy Shevchenko
2026-01-11 12:09 ` Jonathan Cameron
2026-01-23 9:44 ` Jonathan Cameron
2026-01-23 10:08 ` Miclaus, Antoniu
2026-01-23 11:06 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVPMJFt07PG9oHMU@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=suunj1331@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox