From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Liam Beguin" <liambeguin@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 02/11] iio: adc: ltc2309: Improve include relevance
Date: Tue, 20 Jan 2026 09:52:51 +0200 [thread overview]
Message-ID: <aW80U7kH1y9EdnfM@smile.fi.intel.com> (raw)
In-Reply-To: <20260119212110.726941-3-jic23@kernel.org>
On Mon, Jan 19, 2026 at 09:21:01PM +0000, Jonathan Cameron wrote:
>
> Based on output of iwyu, drop kernel.h in favor of more specific includes
> + add some others that are only indirectly included from other headers.
>
> Justification for additions:
> #include <asm/byteorder.h> // for be16_to_cpu
> #include <linux/array_size.h> // for ARRAY_SIZE
> #include <linux/bits.h> // for BIT, GENMASK
> #include <linux/dev_printk.h> // for dev_err, dev_err_probe
> #include <linux/err.h> // for ERR_PTR, EINVAL, ENODEV, ENOMEM
> #include <linux/mod_devicetable.h> // for i2c_device_id, of_device_id
> #include <linux/types.h> // for __be16, u8
Similar comments and one Q here. Should we establish IIO header grouping in all
(touched) drivers? If so, move it outside of linux/*.
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Liam Beguin <liambeguin@gmail.com>
> ---
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 7:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 21:20 [PATCH 00/11] iio: adc: Improve include relevance for some ADCs Jonathan Cameron
2026-01-19 21:21 ` [PATCH 01/11] iio: adc: ltc2471: Improve include relevance Jonathan Cameron
2026-01-20 7:51 ` Andy Shevchenko
2026-01-19 21:21 ` [PATCH 02/11] iio: adc: ltc2309: " Jonathan Cameron
2026-01-20 7:52 ` Andy Shevchenko [this message]
2026-01-19 21:21 ` [PATCH 03/11] iio: adc: max1027: Reorder headers into alphabetical order Jonathan Cameron
2026-01-20 7:53 ` Andy Shevchenko
2026-01-19 21:21 ` [PATCH 04/11] iio: adc: max1027: Improve include relevance Jonathan Cameron
2026-01-20 7:56 ` Andy Shevchenko
2026-01-20 22:10 ` Jonathan Cameron
2026-01-20 22:52 ` Andy Shevchenko
2026-01-21 9:37 ` Nuno Sá
2026-01-19 21:21 ` [PATCH 05/11] iio: adc: max11100: " Jonathan Cameron
2026-01-19 21:21 ` [PATCH 06/11] iio: adc: max11410: Improve relevance of includes Jonathan Cameron
2026-01-19 21:21 ` [PATCH 07/11] iio: adc: ad4130: Improve include relevance Jonathan Cameron
2026-01-19 21:21 ` [PATCH 08/11] iio: adc: ad7124: " Jonathan Cameron
2026-01-19 21:21 ` [PATCH 09/11] iio: adc: ad7124: Replace device.h with more specific includes Jonathan Cameron
2026-01-19 21:21 ` [PATCH 10/11] iio: adc: ad7192: Put headers in alphabetical order Jonathan Cameron
2026-01-19 21:21 ` [PATCH 11/11] iio: adc: ad7192: Improve include relevance Jonathan Cameron
2026-01-20 7:58 ` [PATCH 00/11] iio: adc: Improve include relevance for some ADCs Andy Shevchenko
2026-01-21 9:41 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW80U7kH1y9EdnfM@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alisadariana@gmail.com \
--cc=andy@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox