Re: [PATCH 04/11] iio: adc: max1027: Improve include relevance

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Jan 19, 2026 at 09:21:03PM +0000, Jonathan Cameron wrote:

> Drop kernel.h in favor of more specific headers and add includes that were
> previously relying on other headers including them.
> 
> Whether to include device.h or the relevant sub headers is non obvious.
> In this case, there is an access to struct device for
> spi->dev.driver->name which is used to name the irq.
> 
> The justification from iwyu for the additional includes is:
>   #include <asm/byteorder.h>           // for be16_to_cpu
>   #include <linux/array_size.h>        // for ARRAY_SIZE
>   #include <linux/bitops.h>            // for BIT, GENMASK, fls, hweight32
>   #include <linux/cleanup.h>           // for guard
>   #include <linux/compiler.h>          // for __aligned
>   #include <linux/completion.h>        // for complete, init_completion

>   #include <linux/device.h>            // for dev_err, dev_name, devm_kmal. ..

Not good, we also should treat device.h as "include everything" and try to
avoid that, above comment hints like

dev_printk.h
device/devres.h

>   #include <linux/errno.h>             // for ENOMEM, EINVAL, EBUSY, ETIME...
>   #include <linux/interrupt.h>         // for devm_request_irq, irqreturn
>   #include <linux/jiffies.h>           // for msecs_to_jiffies
>   #include <linux/minmax.h>            // for __cmp_op_max
>   #include <linux/mutex.h>             // for class_mutex_constructor, cla...
>   #include <linux/stddef.h>            // for NULL, false
>   #include <linux/types.h>             // for u8, bool, __be16

> stddef.h not directly included as few drivers do this.

Yes, we assume that types guarantees stddef.h to be provided.

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> ---

Cc here...

>  drivers/iio/adc/max1027.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)

...

> +#include <linux/array_size.h>
> +#include <linux/bitops.h>
> +#include <linux/cleanup.h>

> +#include <linux/compiler.h>

Same as stddef. types.h will bring this.

> +#include <linux/completion.h>
>  #include <linux/delay.h>
> -#include <linux/kernel.h>

> +#include <linux/device.h>

See above.

> +#include <linux/errno.h>
> +#include <linux/interrupt.h>
> +#include <linux/jiffies.h>
> +#include <linux/minmax.h>
>  #include <linux/module.h>
>  #include <linux/mod_devicetable.h>
> +#include <linux/mutex.h>
> +#include <linux/printk.h>
>  #include <linux/spi/spi.h>
> +#include <linux/types.h>

-- 
With Best Regards,
Andy Shevchenko