From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Liam Beguin" <liambeguin@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 00/11] iio: adc: Improve include relevance for some ADCs.
Date: Tue, 20 Jan 2026 09:58:52 +0200 [thread overview]
Message-ID: <aW81vM2hglzIOVF-@smile.fi.intel.com> (raw)
In-Reply-To: <20260119212110.726941-1-jic23@kernel.org>
On Mon, Jan 19, 2026 at 09:20:59PM +0000, Jonathan Cameron wrote:
> So this is a continuation of experimenting with IWYU to ensure that we
> follow what I consider best practice in driver by including all
> headers that are used (subject to some slightly fuzzy rules for some
> of them standard kernel headers).
>
> I was focusing on cases where kernel.h was included and moving from that
> to the more specific headers. That partly explains why there were so
> many headers to add. However, it is also clear that many standard
> headers (mutex.h for example) were missing from these drivers.
>
> There are a few notes and questions in the individual patch descriptions,
> typically where I have either decided to ignore a recommendation or
> conversely have broken things down more finely than IWYU was doing with
> my config files.
>
> All comments welcome. Whilst I don't consider this particular high
> priority (much of it was done in a train where I couldn't access my
> email)m I would like to provide more examples in tree of what I consider
"m"? Bump on the rail that makes your finger slip over keyboard? :-)
> to the right way to do things!
I commented 4 patches, but seems the set of issues I found is repetitive,
So, please address those in all patches and I will look into v2.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 7:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 21:20 [PATCH 00/11] iio: adc: Improve include relevance for some ADCs Jonathan Cameron
2026-01-19 21:21 ` [PATCH 01/11] iio: adc: ltc2471: Improve include relevance Jonathan Cameron
2026-01-20 7:51 ` Andy Shevchenko
2026-01-19 21:21 ` [PATCH 02/11] iio: adc: ltc2309: " Jonathan Cameron
2026-01-20 7:52 ` Andy Shevchenko
2026-01-19 21:21 ` [PATCH 03/11] iio: adc: max1027: Reorder headers into alphabetical order Jonathan Cameron
2026-01-20 7:53 ` Andy Shevchenko
2026-01-19 21:21 ` [PATCH 04/11] iio: adc: max1027: Improve include relevance Jonathan Cameron
2026-01-20 7:56 ` Andy Shevchenko
2026-01-20 22:10 ` Jonathan Cameron
2026-01-20 22:52 ` Andy Shevchenko
2026-01-21 9:37 ` Nuno Sá
2026-01-19 21:21 ` [PATCH 05/11] iio: adc: max11100: " Jonathan Cameron
2026-01-19 21:21 ` [PATCH 06/11] iio: adc: max11410: Improve relevance of includes Jonathan Cameron
2026-01-19 21:21 ` [PATCH 07/11] iio: adc: ad4130: Improve include relevance Jonathan Cameron
2026-01-19 21:21 ` [PATCH 08/11] iio: adc: ad7124: " Jonathan Cameron
2026-01-19 21:21 ` [PATCH 09/11] iio: adc: ad7124: Replace device.h with more specific includes Jonathan Cameron
2026-01-19 21:21 ` [PATCH 10/11] iio: adc: ad7192: Put headers in alphabetical order Jonathan Cameron
2026-01-19 21:21 ` [PATCH 11/11] iio: adc: ad7192: Improve include relevance Jonathan Cameron
2026-01-20 7:58 ` Andy Shevchenko [this message]
2026-01-21 9:41 ` [PATCH 00/11] iio: adc: Improve include relevance for some ADCs Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW81vM2hglzIOVF-@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alisadariana@gmail.com \
--cc=andy@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox