Re: [PATCH 2/2] iio: magn: mmc5633: Add some ifdef / __maybe_unused until stubs available

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Jan 19, 2026 at 10:17:36PM +0000, Jonathan Cameron wrote:

> The I3C tree has Frank Li's fix for the case of I3C not being built

> https://lore.kernel.org/all/20251230145718.4088694-1-Frank.Li@nxp.com/

Make it a Link tag

> Given those will only be available upstream at the next merge window
> and the ordering of merge of I3C vs IIO is uncertain, apply some temporary
> stubs in the driver to avoid build issues.
> 
> This can be reverted next cycle.

Link: ... [1]

> Fixes: 6e5f6bf2e3f0 ("iio: magnetometer: Add mmc5633 sensor")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512280443.lOhY75Df-lkp@intel.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

...

>  static int mmc5633_read_measurement(struct mmc5633_data *data, int address, void *buf, size_t sz)
>  {
>  	struct device *dev = regmap_get_device(data->regmap);
>  	u8 data_cmd[2], status[2];
> -	unsigned int val, ready;
> +	unsigned int val;
> +	unsigned int ready __maybe_unused;
>  	int ret;

Reversed xmas tree ordering?

...

> +#ifdef CONFIG_I3C
>  		ret = i3c_device_do_xfers(data->i3cdev, xfers_wr_cmd,
>  					  ARRAY_SIZE(xfers_wr_cmd), I3C_HDR_DDR);
> +#else

> +		return -EOPNOTSUPP;

I would do one point of return, id est

		ret = -EOPNOTSUPP;

> +#endif
>  		if (ret < 0)
>  			return ret;

...

> +#ifdef CONFIG_I3C
>  		ret = read_poll_timeout(i3c_device_do_xfers, val,
>  					val || (status[0] & ready),
>  					10 * USEC_PER_MSEC,
>  					100 * 10 * USEC_PER_MSEC, 0,
>  					data->i3cdev, xfers_rd_sta_cmd,
>  					ARRAY_SIZE(xfers_rd_sta_cmd), I3C_HDR_DDR);
> +#else
> +		ret = -EOPNOTSUPP;
> +#endif
>  		if (ret) {
>  			dev_err(dev, "data not ready\n");
>  			return ret;
>  		}

Ditto.

-- 
With Best Regards,
Andy Shevchenko