From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
"Jonathan Santos" <Jonathan.Santos@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] iio: adc: ad7768-1: Select GPIOLIB
Date: Mon, 12 Jan 2026 09:23:14 +0200 [thread overview]
Message-ID: <aWShYv4G2oFHh4Fm@smile.fi.intel.com> (raw)
In-Reply-To: <20260111165528.284067-1-jic23@kernel.org>
On Sun, Jan 11, 2026 at 04:55:28PM +0000, Jonathan Cameron wrote:
Thanks for fixing this, my comment below.
> This driver provides a gpio chip a some related functions are not
> stubbed if GPIOLIB is not built.
>
> hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':
> >> drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'
> hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':
> drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
> hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':
> >> drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'
> hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':
> drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
> hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
> drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'
We don't need these many strings, the important ones only would be enough, like
ad7768-1.c:420: undefined reference to `gpiochip_get_data'
ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'
(and also no need to have a full path in this case, we can always read an email
from the LKP below).
> Fixes: ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512271235.WwAmAbOa-lkp@intel.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-12 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 16:55 [PATCH] iio: adc: ad7768-1: Select GPIOLIB Jonathan Cameron
2026-01-12 7:23 ` Andy Shevchenko [this message]
2026-01-12 14:41 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWShYv4G2oFHh4Fm@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Jonathan.Santos@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox