From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] iio: adc: ad9467: include two's complement in default mode
Date: Tue, 13 Jan 2026 23:04:43 +0200 [thread overview]
Message-ID: <aWaza9cRb0kpsE0w@smile.fi.intel.com> (raw)
In-Reply-To: <20260113-b4-ad9467-optional-backend-v2-1-0a27e7e72f41@vaisala.com>
On Tue, Jan 13, 2026 at 12:12:47PM +0000, Tomas Melin wrote:
> All supported drivers currently implicitly use two's complement mode.
> Make this clear by declaring two's complement in the default
> output mode. Calibration mode uses offset binary, so change the output
> mode only when running the calibration or other test mode.
...
> #include <linux/bitmap.h>
> #include <linux/bitops.h>
Side note: bitmap.h implies and guarantees all bit ops to be provided. No need
to include bitops.h when bitmap.h is present.
...
> #define CHIPID_AD9652 0xC1
> +#define AD9652_DEF_OUTPUT_MODE 0x01
> #define AD9652_REG_VREF_MASK 0xC0
Another side note: The other definitions around (mistakenly) have been indented
with spaces. You can see the problem in the diff.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-13 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 12:12 [PATCH v2 0/3] iio: adc: ad9467: Support alternative backends Tomas Melin
2026-01-13 12:12 ` [PATCH v2 1/3] iio: adc: ad9467: include two's complement in default mode Tomas Melin
2026-01-13 21:04 ` Andy Shevchenko [this message]
2026-01-14 7:41 ` Tomas Melin
2026-01-13 12:12 ` [PATCH v2 2/3] iio: industrialio-backend: support backend capabilities Tomas Melin
2026-01-13 15:18 ` David Lechner
2026-01-14 7:29 ` Tomas Melin
2026-01-13 21:06 ` Andy Shevchenko
2026-01-14 7:39 ` Tomas Melin
2026-01-14 7:51 ` Andy Shevchenko
2026-01-13 12:12 ` [PATCH v2 3/3] iio: adc: ad9467: check for " Tomas Melin
2026-01-13 15:19 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWaza9cRb0kpsE0w@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox