Re: [PATCH v2 03/13] iio: pressure: mprls0025pa: fix interrupt flag

Andy Shevchenko
2026-01-14T10:13:38Z

On Wed, Jan 14, 2026 at 12:05:37PM +0200, Petre Rodan wrote:
> Interrupt falling/rising flags should only be defined in the device tree.

...

> if (data->irq > 0) {
> ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> - IRQF_TRIGGER_RISING,
> - dev_name(dev),
> - data);
> + IRQF_TRIGGER_NONE, dev_name(dev), data);

No, this is still incorrect, should be plain 0 here.

> if (ret)
> return dev_err_probe(dev, ret,
> "request irq %d failed\n", data->irq);

--
With Best Regards,
Andy Shevchenko