Re: [PATCH v2 00/13] iio: pressure: mprls0025pa: driver code cleanup

Jonathan Cameron
2026-01-14T12:21:47Z

On Wed, 14 Jan 2026 12:05:34 +0200
Petre Rodan <petre.rodan@subdimension.ro> wrote:

> This series contains a collection of patches to the MPR sensor based
> on feedback I received for other drivers.

Hi Petre,

I took a look at the whole series and didn't have anything to add to
Andy's review.

As we are somewhat near the end of the cycle, if you have time,
feel free to send a v3 sooner than the normal delay of 1ish weeks
(unless there is something you want to wait for more feedback on!)

I'll almost certainly take the lot for the merge window now rather
than trying to get the fixes in this cycle.

Thanks,

Jonathan

>
> major changes:
> - trigger flag fix (define edge direction only in the device tree)
> - fix SPI timing violation
> - fix scan_type struct
> - fix pressure calculation
> (does not affect users that define a sensor via the pressure-triplet)
> - stricter check for the status byte + better error return levels
> - drop the use of devm_kzalloc()
> - stick to the datasheet parameters while performing the measurement
> sequence
>
> minor changes:
> - includes added and removed
> - rename generic 'buffer' variable to 'rx_buf'
>
> I still included the memset patch for the reasons described in the v1 thread.
> if you strongly consider that patch inadequate then please skip it.
>
> Tested on two sensors - MPRLS0015PA0000SA and MPRLS0001BA00001A
>
> Datasheet: https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/micropressure-mpr-series/documents/sps-siot-mpr-series-datasheet-32332628-ciid-172626.pdf?download=false
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> ---
> Changes in v2:
> - reordered patches based on Marcelo's input
> - implemented code changes based on Marcelo and Jonathan's reviews
> - Link to v1: https://lore.kernel.org/r/20251218-mprls_cleanup-v1-0-b36a170f1a5c@subdimension.ro
>
> ---
> Petre Rodan (13):
> iio: pressure: mprls0025pa: fix spi_transfer struct initialisation
> iio: pressure: mprls0025pa: fix SPI CS delay violation
> iio: pressure: mprls0025pa: fix interrupt flag
> iio: pressure: mprls0025pa: fix scan_type struct
> iio: pressure: mprls0025pa: fix pressure calculation
> iio: pressure: mprls0025pa: cleanup includes
> iio: pressure: mprls0025pa: remove redundant declarations
> iio: pressure: mprls0025pa: rename buffer variable
> iio: pressure: mprls0025pa: introduce tx buffer
> iio: pressure: mprls0025pa: move memset to core
> iio: pressure: mprls0025pa: stricter checks for the status byte
> iio: pressure: mprls0025pa: change measurement sequence
> iio: pressure: mprls0025pa: add copyright line
>
> drivers/iio/pressure/mprls0025pa.c | 112 +++++++++++++++------------------
> drivers/iio/pressure/mprls0025pa.h | 15 ++---
> drivers/iio/pressure/mprls0025pa_i2c.c | 13 +---
> drivers/iio/pressure/mprls0025pa_spi.c | 41 +++++-------
> 4 files changed, 73 insertions(+), 108 deletions(-)
> ---
> base-commit: f9e05791642810a0cf6237d39fafd6fec5e0b4bb
> change-id: 20251215-mprls_cleanup-01de8971b439
>
> Best regards,