Re: [PATCH v2 03/13] iio: pressure: mprls0025pa: fix interrupt flag

Jonathan Cameron
2026-01-14T12:14:58Z

On Wed, 14 Jan 2026 12:13:33 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jan 14, 2026 at 12:05:37PM +0200, Petre Rodan wrote:
> > Interrupt falling/rising flags should only be defined in the device tree.
>
> ...
>
> > if (data->irq > 0) {
> > ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> > - IRQF_TRIGGER_RISING,
> > - dev_name(dev),
> > - data);
> > + IRQF_TRIGGER_NONE, dev_name(dev), data);
>
> No, this is still incorrect, should be plain 0 here.

Yeah. My mistake in agreeing with your reply in v1.

I'll randomly blame lack of coffee ;)
See the help text above IRQF_TRIGGER_NONE in interrupt.h which talks about not
specifying up at all (i.e. 0) meaning go with whatever is already there.

Jonathan
>
> > if (ret)
> > return dev_err_probe(dev, ret,
> > "request irq %d failed\n", data->irq);
>