Re: [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure calculation

Andy Shevchenko
2026-01-14T10:15:04Z

On Wed, Jan 14, 2026 at 12:05:39PM +0200, Petre Rodan wrote:
> A sign change is needed for proper calculation of the pressure.
>
> This is a minor fix since it only affects users that might have custom
> silicon from Honeywell that has honeywell,pmin-pascal != 0.
>
> Also due to the fact that raw pressure values can not be lower
> than output_min (400k-3.3M) there is no need to calculate a decimal for
> the offset.

...

> int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)

> struct mpr_data *data;
> struct iio_dev *indio_dev;
> const char *triplet;
> - s64 scale, offset;
> u32 func;
> + s32 tmp;
> + s64 odelta, pdelta;

Please, preserve reversed xmas tree order. And in general try to stick with that one.

--
With Best Regards,
Andy Shevchenko