Re: [PATCH] iio: cros_ec: Allow enabling/disabling calibration mode

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Sun, Jan 18, 2026 at 11:49:28PM -0800, Gwendal Grignou wrote:
> calibration was a one-shot event sent to the sensor to calibrate itself.
  ^ C

> It is used on Bosch sensors (BMI160, BMA254).
> For light sensor, we need to stay in calibration mode to run tests.
> Accept boolean true and false (not just true) to enter/exit calibration.
> 
> Check "echo 0 > calibrate" is supported.

I can somehow understand because the patch is small.  But I believe the
commit message should be rephrased.  For example, if we only need to "stay"
in calibration mode to run tests, why do we need to add the patch for
disabling calibration?

> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 69294f79cc88a..d363d60bb8a36 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -2598,13 +2598,19 @@ struct ec_params_motion_sense {
>  
>  		/*
>  		 * Used for MOTIONSENSE_CMD_INFO, MOTIONSENSE_CMD_DATA
> -		 * and MOTIONSENSE_CMD_PERFORM_CALIB.

Missed a period here but that's also what current ec_commands.h [1] has.
It should be fine.

[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h#3158