From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
lars@metafoo.de, Michael.Hennerich@analog.com,
cosmin.tanislav@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: addac: ad74115: Add missing check for device_property_read_u32_array
Date: Wed, 28 Jan 2026 11:41:04 +0200 [thread overview]
Message-ID: <aXnZsCD01-LUVNGx@smile.fi.intel.com> (raw)
In-Reply-To: <5b0471519e4fdefd41c5d951401483cde3e49f19.camel@gmail.com>
On Wed, Jan 28, 2026 at 09:34:18AM +0000, Nuno Sá wrote:
> On Wed, 2026-01-28 at 12:30 +0800, Chen Ni wrote:
> > Add check for the return value of device_property_read_u32_array() and
> > return the error if it fails in order to catch the error.
...
> > - device_property_read_u32_array(dev, prop_name, vals, 2);
> > + ret = device_property_read_u32_array(dev, prop_name, vals, 2);
> > + if (ret)
> > + return dev_err_probe(dev, ret, "Failed to read %s prop\n",
> > + prop_name);
>
> Thanks for the patch but this is intentional. Not a mandatory property.
No need for further actions. NAK to the change. We don't want to have a monster
with the custom error checking.
P.S. The author also must answer if this was found by some static analyser
tool. If so, the stream from this "tool" should be blocked for now.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-28 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 4:30 [PATCH] iio: addac: ad74115: Add missing check for device_property_read_u32_array Chen Ni
2026-01-28 9:34 ` Nuno Sá
2026-01-28 9:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXnZsCD01-LUVNGx@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox