From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, "Thomas Gleixner" <tglx@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 18/20] iio: magnetometer: Remove IRQF_ONESHOT
Date: Wed, 28 Jan 2026 15:04:30 +0200 [thread overview]
Message-ID: <aXoJXg5JFnFXZqUT@smile.fi.intel.com> (raw)
In-Reply-To: <20260128095540.863589-19-bigeasy@linutronix.de>
On Wed, Jan 28, 2026 at 10:55:38AM +0100, Sebastian Andrzej Siewior wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
> The force-threading functionality is required on PREEMPT_RT because the
> handler is using locks with can sleep on PREEMPT_RT.
>
> Remove IRQF_ONESHOT from irqflags.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-28 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260128095540.863589-1-bigeasy@linutronix.de>
2026-01-28 9:55 ` [PATCH v2 16/20] iio: Use IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-28 13:03 ` Andy Shevchenko
2026-01-29 16:11 ` Jonathan Cameron
2026-01-28 9:55 ` [PATCH v2 17/20] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Sebastian Andrzej Siewior
2026-01-29 16:12 ` Jonathan Cameron
2026-01-28 9:55 ` [PATCH v2 18/20] iio: magnetometer: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-28 13:04 ` Andy Shevchenko [this message]
2026-01-29 16:13 ` Jonathan Cameron
2026-01-28 9:55 ` [PATCH v2 19/20] iio: adc: ad7766: Use iio_trigger_generic_data_rdy_poll() Sebastian Andrzej Siewior
2026-01-28 13:05 ` Andy Shevchenko
2026-01-29 16:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXoJXg5JFnFXZqUT@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dlechner@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox