From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jagath Jog J" <jagathjog1996@gmail.com>,
"Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Fabio Estevam" <festevam@denx.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Eugene Zaikonnikov" <ez@norphonic.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled
Date: Tue, 3 Feb 2026 11:43:35 +0200 [thread overview]
Message-ID: <aYHDR8IS3PwXn9VF@smile.fi.intel.com> (raw)
In-Reply-To: <682cb9e687d1fcf76eb689d7292483c91e3b5b25.1770030812.git.antoniu.miclaus@analog.com>
On Mon, Feb 02, 2026 at 01:26:01PM +0200, Antoniu Miclaus wrote:
> Remove unused drdy_trigger_enabled field from bmi323_data
> struct. The field is declared but never accessed in the
> driver.
...
> struct bmi323_data {
> struct iio_mount_matrix orientation;
> enum bmi323_irq_pin irq_pin;
> struct iio_trigger *trig;
> - bool drdy_trigger_enabled;
Hmm... Not directly related to your series, but with it applied it makes sense
to revisit the structure layouts as they might be rearranged to occupy less
space.
> enum bmi323_state state;
For example, this enum, if moved closer to irq_pin, might result in less gap on
some architectures. (Probably not, as we use long, id est 'int' sized, enums.)
In any way, `pahole` can hint about that, but as I said, it's not for this
series.
> s64 fifo_tstamp, old_fifo_tstamp;
> u32 odrns[BMI323_SENSORS_CNT];
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 11:25 [PATCH v2 00/13] iio: remove unused struct fields across drivers Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 01/13] iio: adc: ad4080: remove unused dec_rate field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 02/13] iio: adc: ad7768-1: remove unused mclk_div field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 03/13] iio: adc: ad7793: remove unused int_vref_mv field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 04/13] iio: adc: ad9467: remove unused output_mode field Antoniu Miclaus
2026-02-02 12:08 ` Tomas Melin
2026-02-02 11:25 ` [PATCH v2 05/13] iio: adc: max1363: remove unused requestedmask field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 06/13] iio: adc: nau7802: remove unused min_conversions field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 07/13] iio: adc: ti-ads1015: remove unused enabled field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 08/13] iio: dac: adi-axi-dac: remove unused int_tone field Antoniu Miclaus
2026-02-02 11:25 ` [PATCH v2 09/13] iio: dac: ti-dac5571: remove unused id field Antoniu Miclaus
2026-02-02 11:26 ` [PATCH v2 10/13] iio: humidity: hdc2010: remove unused interrupt_config Antoniu Miclaus
2026-02-02 11:26 ` [PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled Antoniu Miclaus
2026-02-03 9:43 ` Andy Shevchenko [this message]
2026-02-02 11:26 ` [PATCH v2 12/13] iio: light: apds9306: remove unused nlux_per_count Antoniu Miclaus
2026-02-02 11:26 ` [PATCH v2 13/13] iio: light: gp2ap020a00f: remove unused debug_reg_addr Antoniu Miclaus
2026-02-03 9:44 ` [PATCH v2 00/13] iio: remove unused struct fields across drivers Andy Shevchenko
2026-02-05 20:45 ` Jonathan Cameron
2026-03-03 21:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHDR8IS3PwXn9VF@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=ez@norphonic.com \
--cc=festevam@denx.de \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox