From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Andrew Ijano" <andrew.ijano@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v5 next 2/7] iio: sca3000: switch IRQ handling to devm helpers
Date: Thu, 5 Feb 2026 18:45:29 +0200 [thread overview]
Message-ID: <aYTJKaSt6WkMRIJY@smile.fi.intel.com> (raw)
In-Reply-To: <88524db5-cda6-4529-83db-54ff3b3d5819@oracle.com>
On Thu, Feb 05, 2026 at 10:09:45PM +0530, Harshit Mogalapalli wrote:
> On 05/02/26 21:53, Andy Shevchenko wrote:
> > On Thu, Feb 05, 2026 at 05:12:08AM -0800, Harshit Mogalapalli wrote:
...
> > > - if (spi->irq)
> > > - free_irq(spi->irq, indio_dev);
> >
> > Do we need an irq member to be in the struct after this patch?
>
> I probably didn't understand that question fully.
>
> we still have a call to ret = devm_request_threaded_irq(dev, spi->irq,
> NULL,...) so we can't relaly get rid of the irq member I think,
> did I understand your question right ?
Yes. But now I realised that this is the external structure, and not the one
the driver defines. Sorry for the noise.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-05 16:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 13:12 [PATCH v5 next 0/7] IIO: sca3000: devm resource management Harshit Mogalapalli
2026-02-05 13:12 ` [PATCH v5 next 1/7] iio: sca3000: reuse device pointer for devm helpers Harshit Mogalapalli
2026-02-05 13:12 ` [PATCH v5 next 2/7] iio: sca3000: switch IRQ handling to " Harshit Mogalapalli
2026-02-05 16:23 ` Andy Shevchenko
2026-02-05 16:39 ` Harshit Mogalapalli
2026-02-05 16:45 ` Andy Shevchenko [this message]
2026-02-05 16:49 ` Harshit Mogalapalli
2026-02-05 13:12 ` [PATCH v5 next 3/7] iio: sca3000: Move sca3000_stop_all_interrupts() above sca3000_probe() Harshit Mogalapalli
2026-02-05 16:22 ` Andy Shevchenko
2026-02-05 13:12 ` [PATCH v5 next 4/7] iio: sca3000: make stop_all_interrupts() return void Harshit Mogalapalli
2026-02-05 16:24 ` Andy Shevchenko
2026-02-05 13:12 ` [PATCH v5 next 5/7] iio: sca3000: use guard(mutex) to simplify return paths Harshit Mogalapalli
2026-02-05 16:26 ` Andy Shevchenko
2026-02-05 16:39 ` Harshit Mogalapalli
2026-02-05 13:12 ` [PATCH v5 next 6/7] iio: sca3000: stop interrupts via devm_add_action_or_reset() Harshit Mogalapalli
2026-02-05 16:27 ` Andy Shevchenko
2026-02-05 13:12 ` [PATCH v5 next 7/7] iio: sca3000: manage device registration with devm helper Harshit Mogalapalli
2026-02-05 16:29 ` Andy Shevchenko
2026-02-05 16:51 ` Harshit Mogalapalli
2026-02-05 16:56 ` Andy Shevchenko
2026-02-05 17:00 ` Harshit Mogalapalli
2026-02-05 17:12 ` Andy Shevchenko
2026-02-05 19:58 ` Jonathan Cameron
2026-02-05 20:10 ` Harshit Mogalapalli
2026-03-03 12:14 ` Harshit Mogalapalli
2026-03-03 21:41 ` Jonathan Cameron
2026-03-03 21:44 ` Harshit Mogalapalli
2026-02-05 16:30 ` [PATCH v5 next 0/7] IIO: sca3000: devm resource management Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYTJKaSt6WkMRIJY@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andrew.ijano@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox