From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jorge Marques <jorge.marques@analog.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [bug report] iio: adc: Add support for ad4062
Date: Fri, 6 Feb 2026 16:40:31 +0300 [thread overview]
Message-ID: <aYXvT5FW0hXQwhm_@stanley.mountain> (raw)
In-Reply-To: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
[ Smatch checking is paused while we raise funding. #SadFace
https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
Hello Jorge Marques,
Commit d5284402d28f ("iio: adc: Add support for ad4062") from Dec 17,
2025 (linux-next), leads to the following Smatch static checker
warning:
drivers/iio/adc/ad4062.c:1557 ad4062_probe()
warn: passing positive error code 's32min-(-1),1-3' to 'dev_err_probe'
drivers/iio/adc/ad4062.c
1547 pm_runtime_set_active(dev);
1548 ret = devm_pm_runtime_enable(dev);
1549 if (ret)
1550 return dev_err_probe(dev, ret, "Failed to enable pm_runtime\n");
1551
1552 pm_runtime_set_autosuspend_delay(dev, 1000);
1553 pm_runtime_use_autosuspend(dev);
1554
1555 ret = ad4062_request_ibi(i3cdev);
1556 if (ret)
--> 1557 return dev_err_probe(dev, ret, "Failed to request i3c ibi\n");
The comments for ad4062_request_ibi() say it returns negative error codes
but the comments for i3c_master_enec_locked() say it returns "a positive
I3C error code if the error is one of the official Mx error codes, and
a negative error code otherwise."
1558
1559 ret = ad4062_gpio_init(st);
1560 if (ret)
1561 return ret;
1562
1563 ret = devm_work_autocancel(dev, &st->trig_conv, ad4062_trigger_work);
1564 if (ret)
1565 return ret;
1566
1567 return devm_iio_device_register(dev, indio_dev);
1568 }
regards,
dan carpenter
next prev parent reply other threads:[~2026-02-06 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
2026-02-06 13:40 ` [bug report] iio: dac: adding support for Microchip MCP47FEB02 Dan Carpenter
2026-02-06 14:04 ` Andy Shevchenko
2026-02-06 14:33 ` Dan Carpenter
2026-02-06 15:14 ` Andy Shevchenko
2026-02-06 15:32 ` Dan Carpenter
2026-02-06 15:57 ` Andy Shevchenko
2026-02-10 10:26 ` Ariana.Lazar
2026-03-01 12:31 ` Jonathan Cameron
2026-03-02 10:28 ` Ariana.Lazar
2026-03-03 21:41 ` Jonathan Cameron
2026-02-06 13:40 ` Dan Carpenter [this message]
2026-02-06 14:07 ` [bug report] iio: adc: Add support for ad4062 Andy Shevchenko
2026-03-01 12:34 ` Jonathan Cameron
2026-03-05 17:10 ` Jorge Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXvT5FW0hXQwhm_@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jorge.marques@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox