From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe
Date: Tue, 10 Feb 2026 17:00:07 +0200 [thread overview]
Message-ID: <aYtH96TZ7Wwcd1QZ@smile.fi.intel.com> (raw)
In-Reply-To: <20260210-b4-ad9467-optional-backend-v7-5-7a590ffe02df@vaisala.com>
On Tue, Feb 10, 2026 at 10:53:38AM +0000, Tomas Melin wrote:
> Create alias for the device pointer to simplify referencing
> and keeping syntax and column width shorter.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Some nit-picks in case it will be a new version or Jonathan will be keen to
tweak it.
...
> - st->pwrdown_gpio = devm_gpiod_get_optional(&spi->dev, "powerdown",
> + st->pwrdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
> GPIOD_OUT_LOW);
I would dare to make it a single line.
> if (IS_ERR(st->pwrdown_gpio))
> return PTR_ERR(st->pwrdown_gpio);
...
> - dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n",
> - id, st->info->id);
> + dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", id,
> + st->info->id);
I would not touch the second line as it makes a logical split.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-10 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 10:53 [PATCH v7 0/6] iio: adc: ad9467: Support alternative backends Tomas Melin
2026-02-10 10:53 ` [PATCH v7 1/6] iio: industrialio-backend: support backend capabilities Tomas Melin
2026-02-10 10:53 ` [PATCH v7 2/6] iio: adc: adi-axi-adc: define supported iio-backend capabilities Tomas Melin
2026-02-10 10:53 ` [PATCH v7 3/6] iio: dac: adi-axi-dac: " Tomas Melin
2026-02-10 10:53 ` [PATCH v7 4/6] iio: adc: sd_adc_modulator: " Tomas Melin
2026-02-10 10:53 ` [PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe Tomas Melin
2026-02-10 12:11 ` Nuno Sá
2026-02-10 15:00 ` Andy Shevchenko [this message]
2026-02-10 10:53 ` [PATCH v7 6/6] iio: adc: ad9467: check for backend capabilities Tomas Melin
2026-02-14 15:57 ` [PATCH v7 0/6] iio: adc: ad9467: Support alternative backends Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYtH96TZ7Wwcd1QZ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox