Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management

Andy Shevchenko
2026-02-11T13:30:49Z

On Wed, Feb 11, 2026 at 12:10:11PM +0000, Rodrigo Alencar wrote:
> On 26/02/10 10:05PM, Andy Shevchenko wrote:
> > On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote:
> >
> > > Adhere modern device resource management with the following:
> > > - Voltage regulator managed and enabled internally;
> > > - IIO device registration handled with devm_iio_device_register();
> > > - removal of goto's from the probe function;
> > > - ad8366_remove() removed as it is not needed anymore;
> > >
> > > With the drop of goto's dev_err_probe() is used to report probe errors.
> >
> > I think the regulator change should be split and go before the previous patch,
> > because that one affects the ordering in the error path and remove stage.
>
> OK, that can be done, but the same way,
> the error check would change as well as the dev_err_probe() args, not seeing
> much benefit there as the same lines will have to be touched anyways.

The point is to range the problems and target the more serious one first.
I consider the wrong ordering, (mis)use of devm_*() are in a priority to
just a simple cleanup.

--
With Best Regards,
Andy Shevchenko