Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management

Rodrigo Alencar
2026-02-11T12:10:21Z

On 26/02/10 10:05PM, Andy Shevchenko wrote:
> On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote:
>
> > Adhere modern device resource management with the following:
> > - Voltage regulator managed and enabled internally;
> > - IIO device registration handled with devm_iio_device_register();
> > - removal of goto's from the probe function;
> > - ad8366_remove() removed as it is not needed anymore;
> >
> > With the drop of goto's dev_err_probe() is used to report probe errors.
>
> I think the regulator change should be split and go before the previous patch,
> because that one affects the ordering in the error path and remove stage.

OK, that can be done, but the same way, the error check would change as
well as the dev_err_probe() args, not seeing much benefit there as the same
lines will have to be touched anyways.

--
Kind regards,

Rodrigo Alencar