Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management

Andy Shevchenko
2026-02-10T20:05:30Z

On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote:

> Adhere modern device resource management with the following:
> - Voltage regulator managed and enabled internally;
> - IIO device registration handled with devm_iio_device_register();
> - removal of goto's from the probe function;
> - ad8366_remove() removed as it is not needed anymore;
>
> With the drop of goto's dev_err_probe() is used to report probe errors.

I think the regulator change should be split and go before the previous patch,
because that one affects the ordering in the error path and remove stage.

Otherwise LGTM.

--
With Best Regards,
Andy Shevchenko