From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bhargav Joshi <rougueprince47@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] iio: frequency: ad9523: fix implicit variable usage in macros
Date: Tue, 24 Feb 2026 11:59:36 +0200 [thread overview]
Message-ID: <aZ12iATxw_V7ZmYf@smile.fi.intel.com> (raw)
In-Reply-To: <20260223215636.18606-2-rougueprince47@gmail.com>
On Tue, Feb 24, 2026 at 03:26:34AM +0530, Bhargav Joshi wrote:
> macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and
> AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable
> named 'ret' instead of using passed argument '(x)'.
>
> Update the macros to explicitly
> use the argument '(x)' for their operations.
>
> This also resolves the following checkpatch.pl warning:
> WARNING: Argument '(x)' is not used in function-like macro
Same problem as in v3 stays. Really, go to v3 review and address all comments,
or explain why not.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-24 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 21:56 [PATCH v4 0/3] iio: frequency: ad9523: fix checkpatch Bhargav Joshi
2026-02-23 21:56 ` [PATCH v4 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Bhargav Joshi
2026-02-24 9:59 ` Andy Shevchenko [this message]
2026-02-23 21:56 ` [PATCH v4 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata Bhargav Joshi
2026-02-23 21:56 ` [PATCH v4 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Bhargav Joshi
2026-02-24 9:58 ` [PATCH v4 0/3] iio: frequency: ad9523: fix checkpatch Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ12iATxw_V7ZmYf@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rougueprince47@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox