From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: jic23@kernel.org, antoniu.miclaus@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: fix typos found by codespell
Date: Tue, 24 Feb 2026 16:15:11 +0200 [thread overview]
Message-ID: <aZ2yb8YFih2UuIAy@smile.fi.intel.com> (raw)
In-Reply-To: <20260224122230.67426-1-giorgitchankvetadze1997@gmail.com>
On Tue, Feb 24, 2026 at 04:22:30PM +0400, Giorgi Tchankvetadze wrote:
> Fix various spelling mistakes in comments and error messages
> across drivers/iio/adc/, found by running codespell.
Thanks, my comments below.
...
> v2: expand to fix all typos across drivers/iio/adc/ (Andy)
Do create a new email thread for each new version.
Use proper versioning: `git format-patch -v<N> ...`
<N> = 2 this should be.
...
>
> - /* dummy read: restore default CH0 settin */
> + /* dummy read: restore default CH0 setting */
> return spi_sync(st->spi, &st->msg[AD7887_CH0]);
Please, check the code and perhaps choose a plural form (depending on what is
there in the given register).
...
> #define AD7923_PM_MODE_AS (1) /* auto shutdown */
> #define AD7923_PM_MODE_FS (2) /* full shutdown */
> #define AD7923_PM_MODE_OPS (3) /* normal operation */
> -#define AD7923_SEQUENCE_OFF (0) /* no sequence fonction */
> +#define AD7923_SEQUENCE_OFF (0) /* no sequence function */
> #define AD7923_SEQUENCE_PROTECT (2) /* no interrupt write cycle */
> #define AD7923_SEQUENCE_ON (3) /* continuous sequence */
>
> @@ -39,7 +39,7 @@
> #define AD7923_CHANNEL_WRITE(channel) ((channel) << 6) /* write channel */
> #define AD7923_SEQUENCE_WRITE(sequence) ((((sequence) & 1) << 3) \
> + (((sequence) & 2) << 9))
> - /* write sequence fonction */
> + /* write sequence function */
Nothing is unveiling that the author of that code is French-speaking :-)
...
> * @chip_info: chip specific data
> * @spi: SPI device structure
> - * @vref_mv: voltage reference value in miliVolts
> + * @vref_mv: voltage reference value in milliVolts
millivolts
With units there is a good article on how to spell them in different occasions.
...
Have you run it against Kconfig in the same folder (and subfolders if exists)?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-24 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 11:17 [PATCH] iio: adc: ade9000: fix typo in error message Giorgi Tchankvetadze
2026-02-24 11:26 ` Andy Shevchenko
2026-02-24 12:22 ` [PATCH] iio: adc: fix typos found by codespell Giorgi Tchankvetadze
2026-02-24 14:15 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ2yb8YFih2UuIAy@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox