From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: linusw@kernel.org, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq()
Date: Wed, 25 Feb 2026 13:53:02 +0200 [thread overview]
Message-ID: <aZ7inmsCXRxR94w9@smile.fi.intel.com> (raw)
In-Reply-To: <20260224224818.2452675-5-ethantidmore06@gmail.com>
On Tue, Feb 24, 2026 at 04:48:18PM -0600, Ethan Tidmore wrote:
> The triggered buffer is initialized before the IRQ is requested. The
> removal path currently calls iio_triggered_buffer_cleanup() before
Double space and trailing space.
> free_irq(). This violates the expected LIFO.
Trailing space.
>
> Place free_irq() in correct location.
...
No need to resend unless asked for.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-25 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 22:48 [PATCH v3 0/4] iio: gyro: mpu3050: Multiple bug fixes Ethan Tidmore
2026-02-24 22:48 ` [PATCH v3 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Ethan Tidmore
2026-02-24 22:48 ` [PATCH v3 2/4] iio: gyro: mpu3050: Fix irq resource leak Ethan Tidmore
2026-02-24 22:48 ` [PATCH v3 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Ethan Tidmore
2026-02-28 18:17 ` Jonathan Cameron
2026-02-24 22:48 ` [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Ethan Tidmore
2026-02-25 11:53 ` Andy Shevchenko [this message]
2026-02-25 11:59 ` Andy Shevchenko
2026-02-28 18:15 ` Jonathan Cameron
2026-02-25 12:01 ` [PATCH v3 0/4] iio: gyro: mpu3050: Multiple bug fixes Andy Shevchenko
2026-02-28 18:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ7inmsCXRxR94w9@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox