From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: tsl2772: fix all kernel-doc warnings
Date: Thu, 26 Feb 2026 10:04:53 +0200 [thread overview]
Message-ID: <aZ_-pVTbTUkByPIJ@smile.fi.intel.com> (raw)
In-Reply-To: <20260226051258.555019-1-rdunlap@infradead.org>
On Wed, Feb 25, 2026 at 09:12:57PM -0800, Randy Dunlap wrote:
> Use the correct kernel-doc notation for struct members to eliminate
> kernel-doc warnings:
>
> Warning: include/linux/platform_data/tsl2772.h:88 struct member
> 'prox_diode' not described in 'tsl2772_settings'
> Warning: include/linux/platform_data/tsl2772.h:88 struct member
> 'prox_power' not described in 'tsl2772_settings'
Hmm... I do not see any of the user of this header file.
Have you checked if these values are even used?
Perhaps we can simply kill all this?
But if Jonathan wants to take this as a quick fix to make less
warnings appear effective immediately I'm fine with the change
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-26 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 5:12 [PATCH] iio: tsl2772: fix all kernel-doc warnings Randy Dunlap
2026-02-26 8:04 ` Andy Shevchenko [this message]
2026-02-26 19:14 ` Randy Dunlap
2026-02-26 20:29 ` Andy Shevchenko
2026-02-26 22:25 ` Randy Dunlap
2026-02-28 13:12 ` Jonathan Cameron
2026-02-28 13:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ_-pVTbTUkByPIJ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox