From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] iio: remove redundant else after return
Date: Fri, 20 Feb 2026 16:16:53 +0200 [thread overview]
Message-ID: <aZhs1XSOP1FMXzi5@smile.fi.intel.com> (raw)
In-Reply-To: <aZhsCm4W5ZjLHh0J@smile.fi.intel.com>
On Fri, Feb 20, 2026 at 04:13:35PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 20, 2026 at 03:33:29PM +0200, Antoniu Miclaus wrote:
> > Remove redundant else branches after return statements across several
> > IIO drivers (ad7298, ad7606, ad5592r, ad5758, admv8818) to simplify
> > control flow.
>
> While technically you are correct, the only patch 5 makes sense to me.
> The rest might be better with 'else' be present. It depends on the logic
> between the lines, if they are of the same semantics and it's not about
> returning error code vs. 0 (success), it may be better to read them
> if they are started on the same column.
>
> TL;DR: I am not going to NAK, but patches 1-4 is an unneeded churn to me.
For the record you may look at my patches in the Git history on the same
matter, they do not kill all 'else':s in such cases.
git log --no-merges -p --author="Andy Shevchenko" --grep "redundant 'else'"
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-20 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:33 [PATCH 0/5] iio: remove redundant else after return Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 1/5] iio: adc: ad7298: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 2/5] iio: adc: ad7606: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 3/5] iio: dac: ad5592r-base: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 4/5] iio: dac: ad5758: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 5/5] iio: filter: admv8818: " Antoniu Miclaus
2026-02-20 14:14 ` Andy Shevchenko
2026-02-20 14:13 ` [PATCH 0/5] iio: " Andy Shevchenko
2026-02-20 14:16 ` Andy Shevchenko [this message]
2026-02-22 16:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZhs1XSOP1FMXzi5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox