From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line
Date: Mon, 23 Feb 2026 10:51:29 +0200 [thread overview]
Message-ID: <aZwVEd9LUt4Nsooa@smile.fi.intel.com> (raw)
In-Reply-To: <CAE7dp2oVSDKM2FArSfLtjjUTBm1RPWQNXrsvOgDNvg9G+URogQ@mail.gmail.com>
On Mon, Feb 23, 2026 at 12:40:10PM +0400, Giorgi Tchankvetadze wrote:
> On Mon, Feb 23, 2026 at 12:32 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:
> > > Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> > > line to comply with the kernel coding style for function definitions.
> > > Issue found by checkpatch.
> >
> > Is it the only problem like this in the entire driver?
> > If so, feel free to add
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> Thanks for the review, Andy. Yes, it is the only instance of this
> issue in the driver. I verified with checkpatch and a manual grep for
> function definitions with opening braces on the same line.
Thanks for confirming, no need to resend with my tag, the tooling
Jonathan uses picks this up.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 8:24 [PATCH] iio: adc: ad7173: move opening brace to a separate line Giorgi Tchankvetadze
2026-02-23 8:32 ` Andy Shevchenko
2026-02-23 8:40 ` Giorgi Tchankvetadze
2026-02-23 8:51 ` Andy Shevchenko [this message]
2026-02-23 21:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZwVEd9LUt4Nsooa@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox