[PATCH] iio: adc: ad7173: move opening brace to a separate line

[PATCH] iio: adc: ad7173: move opening brace to a separate line

[Giorgi Tchankvetadze]

Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
line to comply with the kernel coding style for function definitions.
Issue found by checkpatch.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
 drivers/iio/adc/ad7173.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index d36612352b44..f76a9e08f39e 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -1763,7 +1763,8 @@ static int ad7173_validate_openwire_ain_inputs(struct ad7173_state *st,
 static unsigned int ad7173_calc_openwire_thrsh_raw(struct ad7173_state *st,
 						   struct iio_chan_spec *chan,
 						   struct ad7173_channel *chan_st_priv,
-						   unsigned int thrsh_mv) {
+						   unsigned int thrsh_mv)
+{
 	unsigned int thrsh_raw;
 
 	thrsh_raw =
-- 
2.52.0

Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line

[Andy Shevchenko]

On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:
> Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> line to comply with the kernel coding style for function definitions.
> Issue found by checkpatch.

Is it the only problem like this in the entire driver?
If so, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line

[Giorgi Tchankvetadze]

On Mon, Feb 23, 2026 at 12:32 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:
> > Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> > line to comply with the kernel coding style for function definitions.
> > Issue found by checkpatch.
>
> Is it the only problem like this in the entire driver?
> If so, feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Thanks for the review, Andy. Yes, it is the only instance of this
issue in the driver. I verified with checkpatch and a manual grep for
function definitions with opening braces on the same line.

Giorgi

Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line

[Andy Shevchenko]

On Mon, Feb 23, 2026 at 12:40:10PM +0400, Giorgi Tchankvetadze wrote:
> On Mon, Feb 23, 2026 at 12:32 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:
> > > Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> > > line to comply with the kernel coding style for function definitions.
> > > Issue found by checkpatch.
> >
> > Is it the only problem like this in the entire driver?
> > If so, feel free to add
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
> Thanks for the review, Andy. Yes, it is the only instance of this
> issue in the driver. I verified with checkpatch and a manual grep for
> function definitions with opening braces on the same line.

Thanks for confirming, no need to resend with my tag, the tooling
Jonathan uses picks this up.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line

[Jonathan Cameron]

On Mon, 23 Feb 2026 10:51:29 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Feb 23, 2026 at 12:40:10PM +0400, Giorgi Tchankvetadze wrote:
> > On Mon, Feb 23, 2026 at 12:32 PM Andy Shevchenko
> > <andriy.shevchenko@intel.com> wrote:  
> > >
> > > On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:  
> > > > Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> > > > line to comply with the kernel coding style for function definitions.
> > > > Issue found by checkpatch.  
> > >
> > > Is it the only problem like this in the entire driver?
> > > If so, feel free to add
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>  
> > 
> > Thanks for the review, Andy. Yes, it is the only instance of this
> > issue in the driver. I verified with checkpatch and a manual grep for
> > function definitions with opening braces on the same line.  
> 
> Thanks for confirming, no need to resend with my tag, the tooling
> Jonathan uses picks this up.
> 
Applied to the testing branch of iio.git.  I have a bunch of other
stuff I applied tonight that I want the autobuilders to play with
before I push this out as something linux-next will pick up

Thanks,

Jonathan