From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/10] iio: light: gp2ap020a00f: Return directly from the switch cases
Date: Mon, 23 Feb 2026 14:00:43 +0200 [thread overview]
Message-ID: <aZxBaxO_dbPynSzi@smile.fi.intel.com> (raw)
In-Reply-To: <20260223034020.27625-5-ethantidmore06@gmail.com>
On Sun, Feb 22, 2026 at 09:40:14PM -0600, Ethan Tidmore wrote:
> Return directly from the switch cases which makes code easier to follow.
> In some cases convert pieces to the standard pattern which also unifies
> it with the accepted kernel practices.
...
> static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_data *data,
> GP2AP020A00F_OPMODE_SHUTDOWN);
> if (err < 0)
> return err;
> - err = gp2ap020a00f_write_event_threshold(data,
> + return gp2ap020a00f_write_event_threshold(data,
> GP2AP020A00F_THRESH_PL, false);
> - break;
> }
> - return err;
> + return 0;
I would make it also to be a 'default' case. But the driver uses different
styles anyway and I can't easily find a common denominator, so it's fine to
have it like this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 12:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 3:40 [PATCH v5 00/10] General clean up and bug fixes Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 01/10] iio: light: gp2ap020a00f: simplify locking with guard() Ethan Tidmore
2026-02-23 11:54 ` Andy Shevchenko
2026-02-23 3:40 ` [PATCH v5 02/10] iio: light: gp2ap020a00f: correct return type to int Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 03/10] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 04/10] iio: light: gp2ap020a00f: Return directly from the switch cases Ethan Tidmore
2026-02-23 12:00 ` Andy Shevchenko [this message]
2026-02-23 3:40 ` [PATCH v5 05/10] iio: light: gp2ap020a00f: Fix possible error swallow Ethan Tidmore
2026-02-23 12:05 ` Andy Shevchenko
2026-02-23 21:15 ` Jonathan Cameron
2026-02-23 3:40 ` [PATCH v5 06/10] iio: light: gp2ap020a00f: Replace custom implementation of min() Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 07/10] iio: light: gp2ap020a00f: Use temporary variable for struct device Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 08/10] iio: light: gp2ap020a00f: Explicitly use string literal for driver name Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 09/10] iio: light: gp2ap020a00f: Remove trailing comma in termination entry Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 10/10] iio: light: gp2ap020a00f: Join some lines of code to be a single line Ethan Tidmore
2026-02-23 12:16 ` [PATCH v5 00/10] General clean up and bug fixes Andy Shevchenko
2026-02-23 12:17 ` Andy Shevchenko
2026-02-23 21:18 ` Jonathan Cameron
2026-02-24 9:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZxBaxO_dbPynSzi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox