From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/12] iio: frequency: admv1014: introduce struct device variable
Date: Mon, 23 Feb 2026 15:55:10 +0200 [thread overview]
Message-ID: <aZxcPt5W3figzBel@smile.fi.intel.com> (raw)
In-Reply-To: <20260223131418.55414-4-antoniu.miclaus@analog.com>
On Mon, Feb 23, 2026 at 03:13:54PM +0200, Antoniu Miclaus wrote:
> Add struct device *dev local variable to simplify repeated &spi->dev
> dereferences. Where spi is no longer needed beyond &spi->dev, replace
> struct spi_device *spi with struct device *dev = &st->spi->dev.
>
> No functional change.
...
> static int admv1014_init(struct admv1014_state *st)
> {
> unsigned int chip_id, enable_reg, enable_reg_msk;
> - struct spi_device *spi = st->spi;
> + struct device *dev = &st->spi->dev;
> int ret;
>
> ret = regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators);
> if (ret) {
> - dev_err(&spi->dev, "Failed to enable regulators");
> + dev_err(dev, "Failed to enable regulators");
> return ret;
This should be translated to dev_err_probe(). Since devm_*() is used in this
function it's assumed it's only run from ->probe() stage, and hence error
messages may be converted to use dev_err_probe().
> }
...
> if (ret) {
> - dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n");
> + dev_err(dev, "ADMV1014 SPI software reset failed.\n");
> return ret;
> }
Ditto.
...
> if (ret) {
> - dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n");
> + dev_err(dev, "ADMV1014 SPI software reset disable failed.\n");
> return ret;
> }
> ret = __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C);
> if (ret) {
> - dev_err(&spi->dev, "Writing default Temperature Compensation value failed.\n");
> + dev_err(dev, "Writing default Temperature Compensation value failed.\n");
> return ret;
> }
Ditto.
...
> chip_id = FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id);
> if (chip_id != ADMV1014_CHIP_ID) {
> - dev_err(&spi->dev, "Invalid Chip ID.\n");
> + dev_err(dev, "Invalid Chip ID.\n");
> return -EINVAL;
> }
Ditto.
...
> if (ret) {
> - dev_err(&spi->dev, "Writing Quad SE Mode failed.\n");
> + dev_err(dev, "Writing Quad SE Mode failed.\n");
> return ret;
> }
>
> ret = admv1014_update_quad_filters(st);
> if (ret) {
> - dev_err(&spi->dev, "Update Quad Filters failed.\n");
> + dev_err(dev, "Update Quad Filters failed.\n");
> return ret;
> }
>
> ret = admv1014_update_vcm_settings(st);
> if (ret) {
> - dev_err(&spi->dev, "Update VCM Settings failed.\n");
> + dev_err(dev, "Update VCM Settings failed.\n");
> return ret;
> }
Ditto.
...
> static int admv1014_properties_parse(struct admv1014_state *st)
> - ret = devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS,
> + ret = devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS,
> st->regulators);
> if (ret) {
> - dev_err(&spi->dev, "Failed to request regulators");
> + dev_err(dev, "Failed to request regulators");
> return ret;
> }
Same here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 13:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:13 [PATCH v2 00/12] iio: use dev_err_probe in probe path for ADI drivers Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 01/12] iio: frequency: adrf6780: introduce struct device variable Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 02/12] iio: frequency: adrf6780: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 03/12] iio: frequency: admv1014: introduce struct device variable Antoniu Miclaus
2026-02-23 13:55 ` Andy Shevchenko [this message]
2026-02-23 13:13 ` [PATCH v2 04/12] iio: frequency: admv1014: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 13:57 ` Andy Shevchenko
2026-02-23 13:13 ` [PATCH v2 05/12] iio: frequency: admv1013: introduce struct device variable Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 06/12] iio: frequency: admv1013: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 07/12] iio: frequency: adf4377: introduce struct device variable Antoniu Miclaus
2026-02-23 13:13 ` [PATCH v2 08/12] iio: frequency: adf4377: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 13:14 ` [PATCH v2 09/12] iio: dac: ad7293: introduce struct device variable Antoniu Miclaus
2026-02-23 13:14 ` [PATCH v2 10/12] iio: dac: ad7293: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 13:14 ` [PATCH v2 11/12] iio: filter: admv8818: introduce struct device variable Antoniu Miclaus
2026-02-23 13:14 ` [PATCH v2 12/12] iio: filter: admv8818: use dev_err_probe in probe path Antoniu Miclaus
2026-02-23 14:03 ` [PATCH v2 00/12] iio: use dev_err_probe in probe path for ADI drivers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZxcPt5W3figzBel@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox