Re: [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD

[Petre Rodan <petre.rodan@subdimension.ro>]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]


hello,

based on previous feedback [1] IRQF_ONESHOT should be replaced with 0.

[1] https://lore.kernel.org/linux-iio/20260114121448.00000249@huawei.com/

best regards,
peter

On Fri, Feb 27, 2026 at 12:43:51AM +0800, Felix Gu wrote:
> Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
> 
> Replace IRQF_ONESHOT with IRQF_NO_THREAD.
> 
> Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
>  drivers/iio/pressure/abp2030pa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
> index 4ca056a73cef..858e13e02bb4 100644
> --- a/drivers/iio/pressure/abp2030pa.c
> +++ b/drivers/iio/pressure/abp2030pa.c
> @@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
>  	data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
>  
>  	if (data->irq > 0) {
> -		ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> +		ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_NO_THREAD,
>  				       dev_name(dev), data);
>  		if (ret)
>  			return ret;
> 
> ---
> base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
> change-id: 20260227-abp-016a007ab817
> 
> Best regards,
> -- 
> Felix Gu <ustc.gu@gmail.com>
> 

-- 
petre rodan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 870 bytes --]