Re: [PATCH v4] iio: accel: fix ADXL355 startup race condition

[David Lechner <dlechner@baylibre.com>]

On 10/13/25 2:07 AM, Andrej Valek wrote:
> Hello Jonathan,
> 
> 
> 
> On 12.10.2025 17:26, Jonathan Cameron wrote:
>> On Mon,  6 Oct 2025 11:58:12 +0200
>> Andrej Valek <andrej.v@skyrain.eu> wrote:
>>
>>> From: Valek Andrej <andrej.v@skyrain.eu>
>>>
>>> There is an race-condition where device is not full working after SW reset.
>>> Therefore it's necessary to wait some time after reset and verify shadow
>>> registers values by reading and comparing the values before/after reset.
>>> This mechanism is described in datasheet at least from revision D.
>>>
>>> Signed-off-by: Valek Andrej <andrej.v@skyrain.eu>
>>> Signed-off-by: Kessler Markus <markus.kessler@hilti.com>
>> See submitting-patches.rst in documentation for how to format it, but as
>> requested on previous version please reply to this thread with
>> fixes tag.  No need to send a new version.
> I looked into this document, and to be honest didn't find any "issues" in my patch. I used checkpatch and get_maintainer scripts and passed without errors. So what's missing then?

This patch fixes a bug, so it needs a Fixes: tag that describes
the commit that introduced the bug. This information is used to
automatically select the patch for backports to stable kernels
that have the same bug.

So Jonathan was just asking you to reply with the following line...

Fixes: 12ed27863ea3 ("iio: accel: Add driver support for ADXL355")

See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes



>>
>>
>>> ---
>> Change log missing
> What do you mean by this? I didn't find any special document for this. Or do you mean the commit message, if yes, what's missing?


Each time you submit a new revision of a patch/series it should include
a changelog of what was change compared to the previous revisions that
were submitted. And preferably a link to the previous submission as well.
Tools like b4 can automate parts of this for you.

See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#commentary

>>
>> Otherwise looks good to me.
>>
>> Jonathan
>>
>>
> BR,
> Andy