* [PATCH] iio: accel: adxl313: add missing error check in predisable
@ 2026-03-12 11:20 Antoniu Miclaus
2026-03-13 9:41 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Antoniu Miclaus @ 2026-03-12 11:20 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Lucas Stankus,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Lothar Rubusch, Mircea Caprioru, Alexandru Tachici, linux-iio,
linux-kernel
Cc: Antoniu Miclaus
Check the return value of the FIFO bypass regmap_write() before
proceeding to disable interrupts.
Fixes: ff8093fa6ba4 ("iio: accel: adxl313: add buffered FIFO watermark with interrupt handling")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/accel/adxl313_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c
index 9f5d4d2cb325..83dcac17a042 100644
--- a/drivers/iio/accel/adxl313_core.c
+++ b/drivers/iio/accel/adxl313_core.c
@@ -998,6 +998,8 @@ static int adxl313_buffer_predisable(struct iio_dev *indio_dev)
ret = regmap_write(data->regmap, ADXL313_REG_FIFO_CTL,
FIELD_PREP(ADXL313_REG_FIFO_CTL_MODE_MSK, ADXL313_FIFO_BYPASS));
+ if (ret)
+ return ret;
ret = regmap_write(data->regmap, ADXL313_REG_INT_ENABLE, 0);
if (ret)
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: accel: adxl313: add missing error check in predisable
2026-03-12 11:20 [PATCH] iio: accel: adxl313: add missing error check in predisable Antoniu Miclaus
@ 2026-03-13 9:41 ` Andy Shevchenko
2026-03-22 11:48 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-03-13 9:41 UTC (permalink / raw)
To: Antoniu Miclaus
Cc: Lars-Peter Clausen, Michael Hennerich, Lucas Stankus,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Lothar Rubusch, Mircea Caprioru, Alexandru Tachici, linux-iio,
linux-kernel
On Thu, Mar 12, 2026 at 01:20:23PM +0200, Antoniu Miclaus wrote:
> Check the return value of the FIFO bypass regmap_write() before
> proceeding to disable interrupts.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: accel: adxl313: add missing error check in predisable
2026-03-13 9:41 ` Andy Shevchenko
@ 2026-03-22 11:48 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2026-03-22 11:48 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Antoniu Miclaus, Lars-Peter Clausen, Michael Hennerich,
Lucas Stankus, David Lechner, Nuno Sá, Andy Shevchenko,
Lothar Rubusch, Mircea Caprioru, Alexandru Tachici, linux-iio,
linux-kernel
On Fri, 13 Mar 2026 11:41:48 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Mar 12, 2026 at 01:20:23PM +0200, Antoniu Miclaus wrote:
> > Check the return value of the FIFO bypass regmap_write() before
> > proceeding to disable interrupts.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied and marked for stable.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-22 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 11:20 [PATCH] iio: accel: adxl313: add missing error check in predisable Antoniu Miclaus
2026-03-13 9:41 ` Andy Shevchenko
2026-03-22 11:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox