Re: [PATCH v3 3/6] iio: light: vcnl4000: replace mutex_init with devm_mutex_init

David Lechner
2026-03-14T19:51:53Z

On 3/14/26 11:06 AM, Erikas Bitovtas wrote:
> Replace mutex_init used across driver with its device-managed
> counterpart, so all assigned mutexes get destroyed.
>

...

> @@ -1985,6 +1993,7 @@ static int vcnl4000_probe(struct i2c_client *client)
> const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct vcnl4000_data *data;
> struct iio_dev *indio_dev;
> + struct device *dev = &client->dev;

Purely cosmetic, but I would have put this two lines up (right after
*id) to keep assignments and longer lines together.

No need to v4 though, everything else look good.

> int ret;
>
> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));