From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE8C277037; Mon, 16 Mar 2026 11:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659446; cv=none; b=t+LGvVRlKbCAW80hLmnI3NQVlmocT/Gi9a18TstnEHIEtVKhDIqoEEtoqpZvYZ5t4nw3VfOCw9EuEYzNj78fspMxJonhQ4GOexxJXOqno8JuXphl3A6NytXaX+f4VPzLrmoVM9nSfxsRqGRVcU2fRXPjoaZdASHu+RTMSTS7f6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659446; c=relaxed/simple; bh=3SFqd5OOIhAQCqckGxcvojjWJgoNFfQew5xMgcT2ITg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c7TL1h1G96+WUHTqxLcTa28iAyWbnWUFNxmFnI+FMFf69lNBc7MsXUSJGakwf0td9w1xFjm8f+mXnIhsvwHRmgYZUYca8/IacN5+c66ZxW4hgUs06y0MlWh3OKxszjiwLGd18Og0SXZ/u6O9MNLqRJKjdJMLlmaeeybc5YrUjV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gGwhFZAI; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gGwhFZAI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773659445; x=1805195445; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3SFqd5OOIhAQCqckGxcvojjWJgoNFfQew5xMgcT2ITg=; b=gGwhFZAI/Qj3yEOaIewpfVCz0EitHxCBP/PdkJKFiOGrRxAp3K3/0kLQ 9TcHld2PaudrTJa7XAM/9q8ltKC3m/Oxa8EV+HFD7TyqiX6QqNwANlcgE 9RgdFUmGQPpuU7Klv1rXRQe4CmSZeX+ttYcXHdxAQrNW2HvA/t/opNxRb YDyK5KT+XbkMURl9TG2JO+UjaRMkUqym6LC5vksSm7BKjRHP7jrX1TbPN G87dHoExCQSx0bpdfdeXQADmnfdJerJPJP1XcJBQLlitL/0Ng14wXOZrn 1vWmWE4iuZZtGbAzeq6/H8o++re/1jCh1PxHD8CZKsbOQzZs0eNqltPTC A==; X-CSE-ConnectionGUID: l9FLeJy9QU+3GwZtyJkrMw== X-CSE-MsgGUID: 2c+HTmkLRzuZY89Odv7Q9g== X-IronPort-AV: E=McAfee;i="6800,10657,11730"; a="74786678" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="74786678" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 04:10:45 -0700 X-CSE-ConnectionGUID: vwyM9CUoRbmaDiI0gQ8vhA== X-CSE-MsgGUID: A0WD4mprRKS9FM84vS6TcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="221119152" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.237]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 04:10:41 -0700 Date: Mon, 16 Mar 2026 13:10:39 +0200 From: Andy Shevchenko To: Erikas Bitovtas Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances Message-ID: References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> <20260314-vcnl4000-regulators-v3-6-3c4a48d30676@gmail.com> <6cc8f5ab-2671-4975-b24c-b17d4aab656d@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cc8f5ab-2671-4975-b24c-b17d4aab656d@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Mar 16, 2026 at 12:50:48PM +0200, Erikas Bitovtas wrote: > On 3/16/26 12:39 PM, Andy Shevchenko wrote: First of all, remove the content you are not replying to! ... > >> - if (device_property_read_u32(&client->dev, "proximity-near-level", > >> + if (device_property_read_u32(dev, "proximity-near-level", > >> &data->near_level)) > >> data->near_level = 0; > > > > The 'if' is redundant, I think you can drop it at some point, probably to avoid > > churn in the follow up > > > > - if (device_property_read_u32(&client->dev, "proximity-near-level", > > - data->near_level = 0; > > + device_property_read_u32(dev, "proximity-near-level", &data->near_level); > > > > device_property_read_u32() throws an error if a property is missing. > Would data->near_level be left without an assigned default value in that > case? Second, have you read my reply carefully? -- With Best Regards, Andy Shevchenko