Re: [PATCH v4 6/6] iio: adc: Add Intel Dollar Cove TI PMIC ADC driver

[Hans de Goede <hansg@kernel.org>]

Hi Andy,

On 11-Aug-25 9:52 PM, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 5:55 PM Hans de Goede <hansg@kernel.org> wrote:
>>
>> Intel has 2 completely different "Dollar Cove" PMICs for its Bay Trail /
>> Cherry Trail SoCs. One is made by X-Powers and is called the AXP288.
>> The AXP288's GPADC is already supported by the X-Powers AXP288 ADC driver.
>>
>> The other "Dollar Cove" PMIC is made by TI and does not have any clear TI
>> denomination, its MFD driver calls it the "Intel Dollar Cove TI PMIC".
>>
>> Add a driver for the Intel Dollar Cove TI PMIC's general purpose ADC,
>> binding to the "chtdc_ti_adc" MFD cell of the MFD driver.
>>
>> The "cht" in the cell name comes from Cherry Trail, but it turns out that
>> just like the AXP288 the Intel Dollar Cove TI PMIC is also used with both
>> Intel Bay Trail and Intel Cherry Trail SoCs, so this new ADC driver does
>> not include the cht part in its name.
>>
>> This is loosely based on kernel/drivers/iio/adc/iio_dc_ti_gpadc.c
>> from the Acer A1-840 Android kernel source-code archive named:
>> "App. Guide_Acer_20151221_A_A.zip"
>> which is distributed by Acer from the Acer A1-840 support page:
>> https://www.acer.com/us-en/support/product-support/A1-840/downloads

Thank you for the review. I've addressed all your remarks for v5.

...

>> +MODULE_AUTHOR("Ramakrishna Pallala <ramakrishna.pallala@intel.com>");
> 
> Wondering if the address is still alive. In this case perhaps even ask
> for SoB/Co-developed-by? Otherwise if you still wish to have this
> credit make it in the form of "First Last (Intel)".

Good point, I asked about co-maintaining and got a bounce so I'll replace
this with "First Last (Intel)".

Regards,

Hans