public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: David Frey <dpfrey@gmail.com>
To: linux-iio@vger.kernel.org
Cc: jic23@vger.kernel.org, himanshujha199640@gmail.com
Subject: Re: [PATCH v2 4/7] iio: chemical: bme680: change MSK->MASK in #defines
Date: Wed, 15 Aug 2018 14:03:31 -0700	[thread overview]
Message-ID: <ac666b9e-0767-fa08-58e6-2ea9cd3c7f91@gmail.com> (raw)
In-Reply-To: <20180815203835.21079-5-dpfrey@gmail.com>

On 8/15/2018 1:38 PM, David Frey wrote:

<snip>

> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 49bb6b84f181..d62cb88af481 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c

When splitting the patches apart, I screwed this one up slightly.  The 
patch should also include this hunk:

> @@ -206,7 +206,7 @@ static int bme680_read_calib(struct bme680_data *data,
>                 return ret;
>         }
>         calib->par_h1 = (tmp_msb << BME680_HUM_REG_SHIFT_VAL) |
> -                       (tmp_lsb & BME680_BIT_H1_DATA_MSK);
> +                       (tmp_lsb & BME680_BIT_H1_DATA_MASK);
> 
>         ret = regmap_read(data->regmap, BME680_H2_MSB_REG, &tmp_msb);
>         if (ret < 0) {

What is the correct course of action in the situation?  Should I resend 
just this one patch immediately?  Would it get a new version number 
"[PATCH v3 4/7]"?  I think the version number refers to the whole patch 
series, so it seems wrong to bump the revision of one patch and not 
transmit the whole series.

Thanks,
David Frey

  reply	other threads:[~2018-08-15 23:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 20:38 [PATCH v2 0/7] bme680 cleanup David Frey
2018-08-15 20:38 ` [PATCH v2 1/7] iio: chemical: bme680: use clamp macro David Frey
2018-08-15 20:38 ` [PATCH v2 2/7] iio: chemical: bme680: cleanup bme680_read_calib formatting David Frey
2018-08-15 20:38 ` [PATCH v2 3/7] iio: chemical: bme680: indent #defines consistently David Frey
2018-08-15 20:38 ` [PATCH v2 4/7] iio: chemical: bme680: change MSK->MASK in #defines David Frey
2018-08-15 21:03   ` David Frey [this message]
2018-08-16  6:17     ` Himanshu Jha
2018-08-15 20:38 ` [PATCH v2 5/7] iio: chemical: bme680: use GENMASK macro David Frey
2018-08-15 20:38 ` [PATCH v2 6/7] iio: chemical: bme680: use FIELD_GET macro David Frey
2018-08-15 20:38 ` [PATCH v2 7/7] iio: chemical: bme680: simplify oversampling handling David Frey
2018-08-16  6:24 ` [PATCH v2 0/7] bme680 cleanup Himanshu Jha
2018-08-16 12:55   ` David Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac666b9e-0767-fa08-58e6-2ea9cd3c7f91@gmail.com \
    --to=dpfrey@gmail.com \
    --cc=himanshujha199640@gmail.com \
    --cc=jic23@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox