From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Archit Anant <architanant5@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, lars@metafoo.de,
Michael.Hennerich@analog.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] iio: adc: ad799x: use a static buffer for scan data
Date: Thu, 26 Mar 2026 21:11:02 +0200 [thread overview]
Message-ID: <acWExsBF8LGng0L-@ashevche-desk.local> (raw)
In-Reply-To: <20260326180529.19154-3-architanant5@gmail.com>
On Thu, Mar 26, 2026 at 11:35:27PM +0530, Archit Anant wrote:
> Currently, rx_buf is dynamically allocated using kmalloc() every time
> ad799x_update_scan_mode() is called. This can lead to memory leaks if
> the scan mask is updated multiple times.
>
> Drop the dynamic allocation and replace it with a static buffer at the
> end of the state structure using IIO_DECLARE_BUFFER_WITH_TS().
> This eliminates the allocation overhead, prevents leaks, and removes
> the need for manual kfree() on driver removal.
...
> b_sent = i2c_smbus_read_i2c_block_data(st->client,
> - cmd, st->transfer_size, st->rx_buf);
> + cmd, st->transfer_size, (u8 *)st->rx_buf);
Indentation also can be fixed while at it
b_sent = i2c_smbus_read_i2c_block_data(st->client,
cmd, st->transfer_size,
(u8 *)st->rx_buf);
(no need to resend just because of this).
> if (b_sent < 0)
> goto out;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-26 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 18:05 [PATCH v6 0/4] iio: adc: ad799x: modernize resource management Archit Anant
2026-03-26 18:05 ` [PATCH v6 1/4] iio: adc: ad799x: use local device pointer in probe Archit Anant
2026-03-26 18:05 ` [PATCH v6 2/4] iio: adc: ad799x: use a static buffer for scan data Archit Anant
2026-03-26 19:11 ` Andy Shevchenko [this message]
2026-03-26 18:05 ` [PATCH v6 3/4] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-03-26 19:12 ` Andy Shevchenko
2026-03-28 10:56 ` Archit Anant
2026-03-26 18:05 ` [PATCH v6 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove() Archit Anant
2026-03-26 19:15 ` Andy Shevchenko
2026-03-28 11:13 ` Archit Anant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acWExsBF8LGng0L-@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox