From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nia Espera <nespera@igalia.com>,
Luca Weiss <luca.weiss@fairphone.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
Rob <Me@orbit.sh>, Clayton Craft <clayton@igalia.com>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 5/5] arm64: dts: qcom: sm8350-lemonade(p): new devices
Date: Tue, 17 Oct 2023 08:24:20 +0200 [thread overview]
Message-ID: <acc160fb-acf6-4b5b-ae5e-dfe6ec9f78cf@linaro.org> (raw)
In-Reply-To: <49850e9c-5307-489f-9587-f016188bb59a@igalia.com>
On 16/10/2023 23:41, Nia Espera wrote:
>>> +
>>> +&i2c4 {
>>> + touchscreen@48 {
>>> + compatible = "samsung,s6sy761";
>>> + reg = <0x48>;
>>> + interrupts-extended = <&tlmm 23 0x2008>;
>>
>> Replace the 0x2008 with the GPIO_* flags from include/dt-bindings/gpio/gpio.h
>
> There doesn't seem to be a flag for 0x2000 and it's not documented
> downstream; is it okay to replace with (0x2000|GPIO_TRANSITORY)?
Not gpio.h but irq.h. I don't think TLMM supports 2008 as a flag. This
looks wrong.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-17 6:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 12:47 [PATCH 0/5] support oneplus-lemonade(p) devices Nia Espera
2023-10-16 12:47 ` [PATCH 1/5] iio: adc: add smb139x bindings Nia Espera
2023-10-16 13:53 ` Luca Weiss
2023-10-17 19:41 ` Rob Herring
2023-10-16 12:47 ` [PATCH 2/5] arm64: dts: qcom: sm8350: Fix DMA0 address Nia Espera
2023-10-17 15:44 ` Konrad Dybcio
2023-10-17 18:08 ` Nia Espera
2023-10-16 12:47 ` [PATCH 3/5] arm64: dts: qcom: pm8350k: remove hanging whitespace Nia Espera
2023-10-17 15:45 ` Konrad Dybcio
2023-10-16 12:47 ` [PATCH 4/5] arm64: dts: qcom: sm8350: Fix remoteproc interrupt type Nia Espera
2023-10-16 12:47 ` [PATCH 5/5] arm64: dts: qcom: sm8350-lemonade(p): new devices Nia Espera
2023-10-16 13:02 ` Caleb Connolly
2023-10-16 13:14 ` Nia Espera
2023-10-17 16:05 ` Konrad Dybcio
2023-10-16 13:50 ` Luca Weiss
2023-10-16 21:41 ` Nia Espera
2023-10-17 6:24 ` Krzysztof Kozlowski [this message]
2023-10-17 6:31 ` Luca Weiss
2023-10-18 13:47 ` Nia Espera
2023-10-17 16:06 ` Konrad Dybcio
2023-10-18 13:27 ` Nia Espera
2023-10-16 14:33 ` Krzysztof Kozlowski
2023-10-17 16:04 ` Konrad Dybcio
2023-10-17 18:28 ` Nia Espera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc160fb-acf6-4b5b-ae5e-dfe6ec9f78cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Me@orbit.sh \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=clayton@igalia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=nespera@igalia.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox