From: Dan Carpenter <error27@gmail.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math
Date: Sat, 11 Apr 2026 13:52:48 +0300 [thread overview]
Message-ID: <adooAFmov6gF416x@stanley.mountain> (raw)
In-Reply-To: <CALoEA-z0hkOw35D9suEKi61x12fNSSzYem5pecCFj0w_EwLHvA@mail.gmail.com>
On Sat, Apr 11, 2026 at 12:47:42PM +0200, Joshua Crofts wrote:
> On Sat, 11 Apr 2026 at 12:38, Dan Carpenter <error27@gmail.com> wrote:
> > > static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout)
> > > {
> > > - unsigned long long freqreg = (u64)fout *
> > > - (u64)((u64)1L << AD9832_FREQ_BITS);
> > > + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i;
> > ^
> > This extra i char is something I really dread as a vim user. :P
>
> Damn, that's embarrassing... Should I wait 24 hours before submitting a fix
> even if it's this trivial? Thanks.
We're not the boss of you. Do whatever you want to. :P
regards,
dan carpenter
prev parent reply other threads:[~2026-04-11 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:58 [RESEND PATCH v2 0/2] iio: frequency: ad9832: cleanups Joshua Crofts
2026-04-11 8:58 ` [RESEND PATCH v2 1/2] iio: frequency: ad9832: remove kernel.h proxy header Joshua Crofts
2026-04-11 8:58 ` [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Joshua Crofts
2026-04-11 10:38 ` Dan Carpenter
2026-04-11 10:47 ` Joshua Crofts
2026-04-11 10:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adooAFmov6gF416x@stanley.mountain \
--to=error27@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox