Re: [PATCH v2 00/11] Fixes and cleanups for the AD5686 IIO driver

Jonathan Cameron
2026-04-28T16:57:03Z

On Mon, 27 Apr 2026 21:12:07 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Apr 27, 2026 at 12:30:07PM +0100, Rodrigo Alencar via B4 Relay wrote:
> > This is the first series of three on updating the AD5686 driver.
> >
> > A bigger patch series was sent before ("Extend device support for AD5686 driver"),
> > but this is not exactly a v2:
> >
> > https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com
> >
> > This one adds a number of cleanups and fixes, like:
> > - Refactor include headers (IWYU);
> > - Remove redundant register definition;
> > - Drop enum chip id in favor of per-device chip_info structs;
> > - Fix internal voltage reference control for single-channel devices;
> > - Acquire lock when doing power down control;
> > - Fix powerdown control for dual-channel devices;
>
> I have only a few nit-picks, in general LGTM, thanks!
>
>

I had nothing to add :)
Indeed looks good. Just enough in what Andy raised that, given
we are early in the cycle I'd like a v3 rather than tweaking stuff
as I apply,

No need to hold off for usual week I think given nature of
comments (if you have time to respin earlier obviously!)

Thanks,

Jonathan