From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
jic23@kernel.org, lars@metafoo.de, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, nuno.sa@analog.com,
conor.dooley@microchip.com, michael.hennerich@analog.com,
anshulusr@gmail.com, sunke@kylinos.cn, kimseer.paller@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] iio: Fix build error for ltc2664
Date: Wed, 23 Oct 2024 10:41:23 +0200 [thread overview]
Message-ID: <ae939f90-c23f-483b-b4bc-70891d0de167@gmail.com> (raw)
In-Reply-To: <20241023082309.1002917-1-ruanjinjie@huawei.com>
On 23/10/2024 10:23, Jinjie Ruan wrote:
> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
>
> riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
>
> Select REGMAP_SPI for LTC2664 to fix it.
>
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/iio/dac/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..ae6d04c758d1 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -381,6 +381,7 @@ config LTC2664
> tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> depends on SPI
> select REGMAP
> + select REGMAP_SPI
Should you not replace REGMAP with REGMAP_SPI instead?
> help
> Say yes here to build support for Analog Devices
> LTC2664 and LTC2672 converters (DAC).
Best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-10-23 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 8:23 [PATCH] iio: Fix build error for ltc2664 Jinjie Ruan
2024-10-23 8:41 ` Javier Carrasco [this message]
2024-10-23 10:17 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae939f90-c23f-483b-b4bc-70891d0de167@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=anshulusr@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ruanjinjie@huawei.com \
--cc=sunke@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox