From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: magnetometer: ak8975: remove unnecessary braces
Date: Fri, 17 Apr 2026 21:30:14 +0300 [thread overview]
Message-ID: <aeJ8Nlg1DTuvknGA@ashevche-desk.local> (raw)
In-Reply-To: <20260417130224.1308-1-joshua.crofts1@gmail.com>
On Fri, Apr 17, 2026 at 01:02:24PM +0000, Joshua Crofts wrote:
> Remove unnecessary braces at single if statement block.
>
> No functional change.
Code wise is good, but I think it's an unneeded churn as a standalone change.
Up to Jonathan.
...
> ret = i2c_smbus_write_byte_data(data->client,
> data->def->ctrl_regs[CNTL], regval);
> - if (ret < 0) {
> + if (ret < 0)
> return ret;
> - }
> +
> data->cntl_cache = regval;
> /* After mode change wait atleast 100us */
Side note: you can also fix a typo (missing space) and
> usleep_range(100, 500);
move the driver to use fsleep().
(In a separate change.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-17 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 13:02 [PATCH] iio: magnetometer: ak8975: remove unnecessary braces Joshua Crofts
2026-04-17 18:30 ` Andy Shevchenko [this message]
2026-04-19 16:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeJ8Nlg1DTuvknGA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox