Re: [PATCH v2 2/2] iio: adc: mcp3422: write bit operations with bitfield macros

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Apr 17, 2026 at 01:57:47PM -0300, Marcelo Machado Lage wrote:
> Replace manual bit manipulations with FIELD_GET(), FIELD_PREP() and
> FIELD_MODIFY() calls. The resulting code is more readable and
> maintainable, and 6 macros previously defined in the header are not
> needed anymore.

> Following a request by Jonathan Cameron, this version of the patch
> has 3 less macros than v1, now replaced by inline calls of FIELD_GET().
> Thanks, Jonathan! 

This paragraph has to be in the comment block...

> Signed-off-by: Marcelo Machado Lage <marcelomlage@usp.br>
> Co-developed-by: Vinicius Lira <vinilira@usp.br>
> Signed-off-by: Vinicius Lira <vinilira@usp.br>
> ---

...id est somewhere here.

>  drivers/iio/adc/mcp3422.c | 51 +++++++++++++++------------------------
>  1 file changed, 20 insertions(+), 31 deletions(-)

...

> static int mcp3422_read_raw(struct iio_dev *iio,

>  	struct mcp3422 *adc = iio_priv(iio);
>  	int err;
>  
> -	u8 sample_rate = MCP3422_SAMPLE_RATE(adc->config);
> -	u8 pga		 = MCP3422_PGA(adc->config);
> +	u8 sample_rate = FIELD_GET(MCP3422_SRATE_MASK, adc->config);
> +	u8 pga		 = FIELD_GET(MCP3422_PGA_MASK, adc->config);

Please, use common practices and be aligned with the already used style in this
driver. These lines:
- has to be part of the definition block (no blank lines)
- use a single-space indentation approach (no need many spaces before =)
- be located in the form of longest line first (reversed xmas tree order)

-- 
With Best Regards,
Andy Shevchenko