Re: [PATCH v2] iio: temperature: mlx90614: use guard(mutex) for EEPROM access locking

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Apr 20, 2026 at 11:14:29AM -0300, Luiz Mugnaini wrote:

> Replace mutex_lock()/mutex_unlock() pairs with guard() and
> scoped_guard() from cleanup.h for cleaner and safer mutex handling. The
> lock protects EEPROM access across five call sites in
> mlx90614_read_raw(), mlx90614_write_raw(), and mlx90614_sleep().
> 
> In all cases, the code between mutex_unlock() and the end of scope is
> either a return statement, or a call to mlx90614_power_put() followed by
> trivial computation. In the later cases we prefer the use of
> scoped_guard() to avoid holding the lock longer than needed.

...

> @@ -139,6 +140,7 @@ static s32 mlx90614_write_word(const struct i2c_client *client, u8 command,
>  	return ret;
>  }
>  
> +
>  /*
>   * Find the IIR value inside iir_values array and return its position
>   * which is equivalent to the bit value in sensor register

Stray change.

...

>  	dev_dbg(&data->client->dev, "Requesting sleep");

Side note: consider dropping this kind of debug messages. They can be easily
enabled by ftrace infrastructure without being explicitly coded.

-- 
With Best Regards,
Andy Shevchenko