Re: [PATCH] iio: temperature: tsys02d: Use guard(mutex) in tsys02d_write_raw()

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Apr 21, 2026 at 12:40:01PM -0300, lauraarakaki wrote:
> Replace the manual mutex_lock()/mutex_unlock() pair in
> tsys02d_write_raw() with guard(mutex)() from the scope-based
> cleanup helpers (include/linux/cleanup.h).
> 
> The previous code stored the return value of
> ms_sensors_write_resolution() in a local variable solely to
> bridge the gap between the manual mutex_unlock() call and the
> return statement. Using guard(mutex)() removes the need for
> both the intermediate variable and the explicit unlock call,
> since the mutex is released automatically when the function
> goes out of scope.
> 
> No functional change intended.

> Signed-off-by: lauraarakaki <lauraarakaki23@gmail.com>

Read documentation, you need to use real name (as in documents).

> ---
>  
> +#include <linux/cleanup.h>
>  #include <linux/init.h>
>  #include <linux/device.h>
>  #include <linux/kernel.h>

Preferable to get a prerequisite that sorts headers alphabetically and
(optionally) another patch to move to follow IWYU principle.

...

Now the most important point of this review. All of the above you may
get by helping in reviewing the patches in Linux IIO mailing list
(lore.kernel.org/linux-iio).

TL;DR: I will be glad to see a newcomer to participate in the reviewing
first.

-- 
With Best Regards,
Andy Shevchenko