Re: [PATCH v3 1/2] iio: adc: ingenic-adc: refactor ingenic_adc_read_chan_info_raw()

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Apr 21, 2026 at 07:14:58PM -0300, Felipe Ribeiro de Souza wrote:
> Extract the sample logic from ingenic_adc_read_chan_info_raw() into
> a new helper function ingenic_adc_read_chan_locked() to improve code
> readability and modularity.
> 
> The helper handles the mutex-protected section for sampling channels,
> while the main function manages clock enabling/disabling.

...

> +static int ingenic_adc_read_chan_info_raw(struct iio_dev *iio_dev,
> +					  struct iio_chan_spec const *chan,
> +					  int *val)
> +{
> +	int ret;
> +	struct ingenic_adc *adc = iio_priv(iio_dev);

Please, keep it as in reversed xmas tree order.

> +	ret = clk_enable(adc->clk);

> +

Redundant blank line.

> +	if (ret) {
> +		dev_err(iio_dev->dev.parent, "Failed to enable clock: %d\n",
> +			ret);

Make it a single line. It's fine to go a bit over 80 for readability purposes.

> +		return ret;
> +	}
> +
> +	ret = ingenic_adc_read_chan_locked(adc, chan, val);
> +
>  	clk_disable(adc->clk);
>  
>  	return ret;

-- 
With Best Regards,
Andy Shevchenko