From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: rafasales@usp.br
Cc: andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
nuno.sa@analog.com, "Gustavo C. Arakaki" <gustavo.arakaki@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 3/3] iio: light: ltr501: use `sysfs_emit_at()` for showing scales
Date: Fri, 24 Apr 2026 12:34:28 +0300 [thread overview]
Message-ID: <aes5JB9_1GH4fEei@ashevche-desk.local> (raw)
In-Reply-To: <20260422231305.677778-4-rafasales@usp.br>
On Wed, Apr 22, 2026 at 08:12:57PM -0300, rafasales@usp.br wrote:
> Replace `scnprintf()` with `sysfs_emit_at()`, which is
> PAGE_SIZE-aware and preferred for use in sysfs.
...
> for (i = 0; i < info->ps_gain_tbl_size; i++) {
> if (info->ps_gain[i].scale == LTR501_RESERVED_GAIN)
> continue;
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ",
> + len += sysfs_emit_at(buf, len, "%d.%06d ",
> info->ps_gain[i].scale,
> info->ps_gain[i].uscale);
It broke indentation now.
...
> for (i = 0; i < info->als_gain_tbl_size; i++) {
> if (info->als_gain[i].scale == LTR501_RESERVED_GAIN)
> continue;
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ",
> + len += sysfs_emit_at(buf, len, "%d.%06d ",
> info->als_gain[i].scale,
> info->als_gain[i].uscale);
Ditto.
> }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-24 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 23:12 [PATCH v3 0/3] iio: light: ltr501: cleanups and modernizations rafasales
2026-04-22 23:12 ` [PATCH v3 1/3] iio: light: ltr501: update header inclusions rafasales
2026-04-24 9:27 ` Andy Shevchenko
2026-04-22 23:12 ` [PATCH v3 2/3] iio: light: ltr501: use automatic cleanup of locks rafasales
2026-04-24 9:33 ` Andy Shevchenko
2026-04-24 11:32 ` Jonathan Cameron
2026-04-22 23:12 ` [PATCH v3 3/3] iio: light: ltr501: use `sysfs_emit_at()` for showing scales rafasales
2026-04-24 9:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aes5JB9_1GH4fEei@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavo.arakaki@usp.br \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rafasales@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox