From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA5A36C9F4 for ; Fri, 24 Apr 2026 08:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777017783; cv=none; b=jQBU+1krNa/yv6FfwkUXSBIYt3lvNQUaaVbf60kVCWsVVU64fWRtURnRRN7rBFZjOgg2+bBDrJnQIsxNHj+Etj2loyQ9GAyBdR9rfIxCtZMN+NHnoF1o2P+SKx8CTjcCmPfcwUeJOAOdmc7qb+unpOmEdTV4ZhoVOarXxr8SQUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777017783; c=relaxed/simple; bh=Hj1tOHvncsJQ+78/m2uGWzzPNp6G6CHf+6pvVXpzTcg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fjy2na3d9wscMYAPyazhDhoSuljCN1FRoGpxy+IyP9722boa/zezQR9t13/1Yi4FT3nDZLTsnKAOmSqCI+3jz9hxxS/lOkJ6mviN+fZrNUyPeAwcR12/SwFvz2N9ho5VSh+3fZvQ612dW0ILp5UiSn4Bqpq2UZwDKmigQXiYG1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NjIpbkR7; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NjIpbkR7" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4891c00e7aeso50469775e9.2 for ; Fri, 24 Apr 2026 01:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777017779; x=1777622579; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Itef6o5U+8hhDJZnzY0W0DUQufh1131w2DOWcXoqxCE=; b=NjIpbkR7tt9BS/Uj3eRrp2RnlbW6toliQsFDAOaFhI1Hu9CjpROKHavE1MnzsSavXo 3bILRojtAHSNpnvdxBgTarU1383dF2CgDJ9qNG3VRti+zSzGac97/lUC6FMVm8Y45iOg lnrnaNHZ2//R3+tSnDogDDqIeOFtX9LF6KVELfwux1fa+wZ2MMhx2/Ip8jZnG9TgqJvh 5dAuD9Az8N9WUFv4/f3dcLr9n0nTM8tsABBd3pUU8OYXeP7wwS4uZ38xnmVvdqKaot9V 5B/J/Tl+S1J22ZdxNprUOhSpw3UgK8M4x6qCZJwLqEgsBKrBYc+M/oe4+stt1OQ8zx22 jREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777017779; x=1777622579; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Itef6o5U+8hhDJZnzY0W0DUQufh1131w2DOWcXoqxCE=; b=nzRtVtgQi7yuPJ2mY6MEPimmzjVahPl+jZ0qf+zfz6gR3elMXpkAk82R7sqIOm653H jnHvIt1KcrP1WCO1YiMcO58FW6YOWiMkPuoJUoAKCVZrKr+eSURBbJHmP1pZhLUL+rHZ M0Wgjy04qZf87rJXJ+31+JmHYZefG3HUGQdDVDYU6Xp8gswtB9h6j6Ja/hrWzJytWCnt BrtO+E4r1ckkwyR72jjF3teE66uXiXT6bKe3YYJ1cV9wgw+IAPBdAMeL0FkM6Y2NTQ1d O4jiBPm+gRGpw8j9jM2peqOmM0c8XfOFbFi1DQKkmVU6U8Zr4QLDYsdQXbOplQ0W7qDF ee5Q== X-Forwarded-Encrypted: i=1; AFNElJ+vSikdXaA2SNqbV6GLYV5YXJG4yzOaT48+dua0yP/5yZBvzYHaRuTZRIvTh5GUCDHt07/cTg/dHmI=@vger.kernel.org X-Gm-Message-State: AOJu0YyRg77yLhuEv8Iv6eNmFWNxXx+1OGEwgEPphnvgcovWrXbjhxvE HKgG17No9HaUahBmiT0DliOyruQmSAZGk0+y4a/GEt9+CcHK/IalrW5Z X-Gm-Gg: AeBDietbcxJmwY8JCP3xjdP+RPf2Y2lbcI7zCOmKJEhcrjHlLf3xJ+fAww9L9fUfVA8 06L9dLSYq21mDm8PLD4ZU9OJpwRk+y7fm+y6QUzVDXRRD2iZidWwhFttweoK1ve/4tqtIlOIWP3 omNGyQYGNJcbpVwQ3zrM3JyYIAV4OA0KoY5uncCYfXadlQH/of16jaUltxjTqQ2v2nbHfc0x2NM Ayf3gH55TIIwPAoJxKmVnwrKmFvvZb1XDAbWHgW/L3rTT02CDoYisu6xjH10yW2SoXaupuyBq7e P2qoeEA66rbDB0Kq+cbydZ7KT1NFXUiJbWm72Pf4t8yPc/sKlRuNYsikr6ji6guEy+STE5uE0US U4LGWtgOUrGr2yKwEggnFG2zgL3knrYU0iYeovS3A7stOZ30a9FibZ81Nhg53b0jL8AIJukNO0D fDU4gn7yYCISh8gTZdMG9YMcE= X-Received: by 2002:a05:600c:3110:b0:487:243f:dc3e with SMTP id 5b1f17b1804b1-488fb739cf6mr445107995e9.6.1777017779044; Fri, 24 Apr 2026 01:02:59 -0700 (PDT) Received: from nsa ([185.128.9.42]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d5b1sm62272531f8f.30.2026.04.24.01.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 01:02:58 -0700 (PDT) Date: Fri, 24 Apr 2026 09:03:49 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Jonathan Cameron Cc: Rodrigo Alencar via B4 Relay , rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Auchter , linux-hardening@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , "Gustavo A. R. Silva" , Philipp Zabel Subject: Re: [PATCH 13/22] iio: dac: ad5686: fix input raw value check Message-ID: References: <20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com> <20260422-ad5313r-iio-support-v1-13-ed7dca001d1b@analog.com> <20260423190302.338ecdbe@jic23-huawei> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260423190302.338ecdbe@jic23-huawei> On Thu, Apr 23, 2026 at 07:03:02PM +0100, Jonathan Cameron wrote: > On Wed, 22 Apr 2026 15:45:47 +0100 > Rodrigo Alencar via B4 Relay wrote: > > > From: Rodrigo Alencar > > > > Use in_range() to fix range check for input raw value, which is off by > > one, i.e., for a 10-bit DAC the max valid value is 1023, but 1 << 10 > > equals 1024, which passes the previous check, allowing an out-of-range > > write. > > > > Signed-off-by: Rodrigo Alencar > > --- > > drivers/iio/dac/ad5686.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c > > index 19d791c655b7..07a944311f0e 100644 > > --- a/drivers/iio/dac/ad5686.c > > +++ b/drivers/iio/dac/ad5686.c > > @@ -185,7 +185,7 @@ static int ad5686_write_raw(struct iio_dev *indio_dev, > > > > switch (mask) { > > case IIO_CHAN_INFO_RAW: > > - if (val > (1 << chan->scan_type.realbits) || val < 0) > > + if (!in_range(val, 0, 1 << chan->scan_type.realbits)) > > Might just be me, but I do find in range a bit weird when the offset is 0. > > I'd be tempted to just make the check >= FWIW, I also don't love the fact that we need to define the range instead of pure min/max. But in this case, given that "min" is 0 it actually works without extra defines :) Having said the above, no preferences on my side. - Nuno Sá > > > return -EINVAL; > > > > mutex_lock(&st->lock); > > >