From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Gabriel Braga Lagrotaria de Oliveira <gabrielblo@ime.usp.br>
Cc: David Lechner <dlechner@baylibre.com>,
javier.carrasco.cruz@gmail.com, jic23@kernel.org,
nuno.sa@analog.com, andy@kernel.org,
Ricardo H H Kojo <ricardo.kojo@ime.usp.br>,
Ellian Carlos <elliancarlos@gmail.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035
Date: Tue, 28 Apr 2026 11:07:39 +0300 [thread overview]
Message-ID: <afBqyxeBa0hl3ILr@ashevche-desk.local> (raw)
In-Reply-To: <CAOmGE-1108GJobu8nNc=WnV-+WFeW-LF2j0fQ+aMv9Ke27HOqw@mail.gmail.com>
On Mon, Apr 27, 2026 at 08:32:49PM -0300, Gabriel Braga Lagrotaria de Oliveira wrote:
> Thank you for the feedback! We have one remaining question regarding the
> naming conventions: while adding the init_config pointer to the chip
> structure, we noticed the structure name itself (veml603x_chip) includes
> the 'x' wildcard. Should we rename this to a specific model or keep it
> as-is for the v2 submission?
Stop top-posting!
> Em seg., 20 de abr. de 2026 às 18:00, David Lechner <dlechner@baylibre.com>
> escreveu:
> > On 4/20/26 3:14 PM, Gabriel Braga Lagrotaria wrote:
> > > Add a new veml603x_hw_init() function to deduplicate the setup logic
> > > for veml6030_hw_init() and veml6035_hw_init().
> > >
> > > Additionally, introduce struct veml603x_hw_init_config to store and
> > > pass the custom configuration values specific to each device variation.
--
With Best Regards,
Andy Shevchenko
next parent reply other threads:[~2026-04-28 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260420201441.18055-1-gabrielblo@ime.usp.br>
[not found] ` <26330121-79bd-4273-b8e4-17efa19454eb@baylibre.com>
[not found] ` <CAOmGE-1108GJobu8nNc=WnV-+WFeW-LF2j0fQ+aMv9Ke27HOqw@mail.gmail.com>
2026-04-28 8:07 ` Andy Shevchenko [this message]
[not found] ` <CAOmGE-3_WYpL0AFpV-NcF=yZ2SBvUrSELuc=VXb=UVKGBbxnvw@mail.gmail.com>
2026-04-28 18:07 ` [PATCH] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBqyxeBa0hl3ILr@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=elliancarlos@gmail.com \
--cc=gabrielblo@ime.usp.br \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ricardo.kojo@ime.usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox